Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gonad #7504

Closed
dustymc opened this issue Mar 8, 2024 · 38 comments
Closed

gonad #7504

dustymc opened this issue Mar 8, 2024 · 38 comments

Comments

@dustymc
Copy link
Contributor

dustymc commented Mar 8, 2024


Cleanup


https://arctos.database.museum/info/ctDocumentation.cfm?table=ctattribute_type#gonad

gonad needs cleaned up, very few records, easy if we act before it gets used more

 guid_prefix | count 
-------------+-------
 MLZ:Bird    |     1
 ANSP:Host   |  1625

(no contacts available)

Please note that this has about 1624 more records than it did when we started this, if values The Community does not want to support are in the tables they WILL be used, if we are going to do something let's do it now.

Suggest we move this to reproductive data if we are to remove this term.


#6189

right gonad width (already misconfigured, nonsense data cannot be trusted) needs migration - suggest we move this to reproductive data, including a note about the conflict between the definition and term, if we plan to remove this term.

https://arctos.database.museum/info/ctDocumentation.cfm?table=ctattribute_type#right_gonad_width


 guid_prefix | count 
-------------+-------
 UMNH:Mamm   |     1
 BYU:Bird    |   465
 UCSC:Mamm   |     1
 MVZ:Mamm    |    22
 UNR:Mamm    |     1
 MMNH:Bird   |    18
 MMNH:Mamm   |     1
 MVZ:Herp    |    40
 HSUVM:Mamm  |     6
 KSB:Mamm    |     1
 UAM:Mamm    |     1
 UMZM:Bird   |    22
 UMNH:Bird   |     8
 OWU:Bird    |     7
 MLZ:Bird    |     9
 UMZM:Mamm   |    23
 UCM:Bird    |    47

@amgunderson
@adhornsby
@mkoo
@cjconroy
@atrox10
@ebraker
@kderieg322079
@asemerdj
@jrpletch
@byuherpetology


right gonad length [ link ]


 guid_prefix | count 
-------------+-------
 UMNH:Mamm   |     2
 BYU:Bird    |   465
 UCSC:Mamm   |     1
 MVZ:Mamm    |    22
 UNR:Mamm    |     1
 MMNH:Bird   |    18
 UTEP:Bird   |     1
 MMNH:Mamm   |     1
 MVZ:Herp    |   177
 HSUVM:Mamm  |     6
 UAM:Mamm    |     1
 UMZM:Bird   |    22
 UMNH:Bird   |     5
 UWBM:Mamm   |    85
 OWU:Bird    |     7
 MLZ:Bird    |     9
 UMZM:Mamm   |    23
 UCM:Bird    |    47

@amgunderson
@adhornsby
@mkoo
@cjconroy
@atrox10
@jebrad
@mvzhuang
@ebraker
@kderieg322079
@asemerdj
@jrpletch
@byuherpetology


left gonad length [ link ]


 guid_prefix | count 
-------------+-------
 UNR:Mamm    |     2
 MMNH:Bird   |    37
 MVZ:Herp    |   153
 HSUVM:Mamm  |     6
 APSU:Bird   |   112
 MLZ:Bird    |   217
 UMZM:Mamm   |    21
 UCM:Bird    |    50
 UMNH:Mamm   |     1
 UCSC:Mamm   |     4
 UTEP:Bird   |     2
 KSB:Mamm    |   308
 UMZM:Bird   |    44
 UMNH:Bird   |    10
 MSB:Mamm    |     2
 UWBM:Mamm   |   111
 OWU:Bird    |     5
 BYU:Bird    |   510

@ebraker
@byuherpetology
@mkoo
@campmlc
@kderieg322079
@atrox10
@mvzhuang
@asemerdj
@adhornsby
@jebrad
@gradyjt
@jrpletch
@AdrienneRaniszewski
@jldunnum


left gonad width [ link ]

 guid_prefix | count 
-------------+-------
 UNR:Mamm    |     2
 MMNH:Bird   |    37
 MVZ:Herp    |    62
 HSUVM:Mamm  |     6
 APSU:Bird   |   112
 MLZ:Bird    |   218
 UMZM:Mamm   |    21
 UCM:Bird    |    49
 UMNH:Mamm   |     1
 UCSC:Mamm   |     4
 UTEP:Bird   |     1
 KSB:Mamm    |   303
 UMZM:Bird   |    44
 UMNH:Bird   |     7
 OWU:Bird    |     4
 BYU:Bird    |   510

@ebraker
@byuherpetology
@mkoo
@kderieg322079
@atrox10
@mvzhuang
@asemerdj
@adhornsby
@gradyjt
@jrpletch


Done


#7503

gonad weight - already there, updated definition


added
https://github.com/ArctosDB/code-table-work/issues/63

New gonad width attribute, needs approved and implemented


added


https://github.com/ArctosDB/code-table-work/issues/14

New gonad length attribute, needs approved and implemented

20240906 still no action

@dustymc dustymc added this to the Active Development milestone Mar 8, 2024
@Jegelewicz
Copy link
Member

Email to AWG today:

Arctos Working Group Member,

In an effort to increase discoverability of data and keep the Arctos Code Tables efficient, changes will soon be made to catalog record attributes related to gonads.

For a summary of the issues and effort, please see #7504

When this process is completed, there will be three gonad attributes:

gonad length - Measurement of the long axis of the gonad (which may be testes or ovary and can be indicated in Remarks or by implication of attribute of sex). Left or right side gonad should be indicated in the Methods.

gonad width - Measurement of the short axis of the gonad (which may be testes or ovary and can be indicated in Remarks or by implication of attribute of sex). Left or right side gonad should be indicated in the Methods.

gonad weight - Weight measurement of the gonad (which may be testes or ovary and can be indicated in Remarks or by implication of attribute of sex). Left or right side gonad should be indicated in the Methods.

The following terms will be removed from the catalog record attribute code table and the values currently there will be migrated as detailed.

right gonad width - will become gonad width with right placed in the attribute method.

right gonad length - will become gonad length with right placed in the attribute method.

left gonad width - will become gonad width with left placed in the attribute method.

left gonad length - will become gonad length with right placed in the attribute method.

If you have concerns about your data, please comment on the various issues. Migration to the new terms will take place on April 11, 2024. If you want to handle your data on your own, this allows time for that, or you may request assistance in any of the issues.

Thank you! 

 

Teresa J. Mayfield-Meyer

@dustymc
Copy link
Contributor Author

dustymc commented Aug 27, 2024

I'm adding to AWG agenda; we're 6 months into what seems like it should have been a half-day problem, suggest we convert all involved data to https://arctos.database.museum/info/ctDocumentation.cfm?table=ctattribute_type#reproductive_data and drop the individual attributes if a better and actionable solution cannot be identified.

@campmlc
Copy link

campmlc commented Aug 27, 2024

These data are being converted out of https://arctos.database.museum/info/ctDocumentation.cfm?table=ctattribute_type#reproductive_data as part of the grant funded Ranges project. These stakeholders need to be involved.
@jldunnum @bryansmclean @mkoo

@dustymc
Copy link
Contributor Author

dustymc commented Aug 27, 2024

need to be involved

PLEASE! I believe all issues are linked above, proceeding with the initial plan is still perfectly fine with me and I'm happy to do whatever I can to facilitate that. Getting stuck in the middle where nobody can understand the increasingly-scattered data (where we are now) should not be an acceptable position for anyone. HELP!

@bryansmclean
Copy link

I would love to help sort this out and finalize the consensus decision.

AWG @ Thursday, September 5, 2024?

@jldunnum
Copy link

jldunnum commented Aug 27, 2024 via email

@campmlc
Copy link

campmlc commented Aug 28, 2024

@bryansmclean @jldunnum can you suggest a meeting time for when you are both available to discuss? I think it would be good to go over this outside of the AWG to review what has been done so far and what is still needed. @mkoo

@bryansmclean
Copy link

  • This Friday (30 Aug) from 11-1 ET
  • anytime next Monday (2 Sept) or Wed (4 Sept)

@dustymc
Copy link
Contributor Author

dustymc commented Aug 28, 2024

consensus

As far as I know that is done and does not need more. The first comment outlines what is needed - the addition of one attribute, and ~5 cleanup issues.

@bryansmclean
Copy link

consensus

As far as I know that is done and does not need more. The first comment outlines what is needed - the addition of one attribute, and ~5 cleanup issues.

I am not seeing discussion or documentation of a consensus on other related proposed repro attributes

I agree that it would be great to finalize but my memory of how we decided to do that is now hazy

@dustymc
Copy link
Contributor Author

dustymc commented Aug 28, 2024

discussion

Link to AWG notes in first comment.

That said: I wholeheartedly agree, we need a mechanism to finish to the things we start on a timeline. The Community has made a decision, there's a clear path to implementation, hanging out for months while the data get worse and more confusing at that point should not happen. I'm always happy to update, just need a little direction and support.

@bryansmclean
Copy link

bryansmclean commented Aug 28, 2024

We will prepare to discuss this on 5 Sept @ AWG if that sounds good to all. I think a short recap of the community consensus makes sense at that mtg. Please let me know if this doesn't work

@dustymc
Copy link
Contributor Author

dustymc commented Sep 6, 2024

rediscussed 20240905 AWG meeting, I don't know if progress was made or not - @bryansmclean ??

I'm going to consolidate some things here, I can't keep up with the scattered issues, maybe I'm not alone...

@dustymc
Copy link
Contributor Author

dustymc commented Sep 6, 2024

This just keeps getting more messy, and has now become disruptive to incoming collections. Can we find some quick conclusion and implement that, please? @bryansmclean @mkoo help!

FWIW all of this still looks a lot like https://arctos.database.museum/info/ctDocumentation.cfm?table=ctattribute_type#reproductive_data to me, and several collections have cleaned up parts of this in that direction.

@bryansmclean
Copy link

I think that our consensus was to move left and right gonad lengths and widths to the "gonad length" and "gonad width" fields

The one pre-requisite is to create a controlled vocabulary for methods with all possible positions (left, right, left and right combined, side unknown)

@bryansmclean
Copy link

bryansmclean commented Sep 6, 2024

The one pre-requisite is to create a controlled vocabulary for methods with all possible positions (left, right, left and right combined, side unknown)

FWIW, Creating this structural change will benefit pending requests for future mammal traits since placental scars, embryo counts, etc all require position statements

Should I log a new issue for that?

@dustymc
Copy link
Contributor Author

dustymc commented Sep 6, 2024

pre-requisite is to create a controlled vocabulary for methods

That would be some model other than the one we have, please comment here: #6742

EDIT: Even if someone has a clear vision for a model which will solve all of our attribute woes (I do not!), I don't think we should wait for it to be developed and implemented. This is clearly and demonstrably causing problems for incoming collections, that is in my view WAY more evil than eg tossing these data into reproductive data for safe keeping while we decide on a better path.

@campmlc
Copy link

campmlc commented Sep 6, 2024

We have a consensus on what to do here: follow the March 21 recommendations above. All the ANSP data recently loaded by @Jegelewicz ( and more of the same in the attribute component loader that I have control over) need to be converted to gonad length and gonad width attributes as soon as they exist,which should be immediately.
@bryansmclean and others in the issues meeting yesterday discussed a code table for positions, eg left, right, left and right, unknown etc, that could be used for methods for these types of dimensional attributes. There was general support for this. It needs a new issue. As that may take some time to discuss, in the meantime, these positional values should go in methods as free text.
I recommend making the above changes immediately and getting rid of the gonad attribute.

@bryansmclean
Copy link

getting rid of the gonad attribute

I agree with this as well. Any other gonad attributes besides measurements are good for free text in the reproductive data field.

@dustymc
Copy link
Contributor Author

dustymc commented Sep 6, 2024

converted to gonad length and gonad width attributes

If you're volunteering, here are the data:

temp_gonad.csv.zip

@dustymc
Copy link
Contributor Author

dustymc commented Sep 6, 2024

as soon as they exist,

Done, I'm not letting that impede any momentum here.

@dustymc
Copy link
Contributor Author

dustymc commented Sep 6, 2024

@campmlc or anyone else: if you need any other data, please let me know. There are now eg 3 'gonad length' attributes, that should not exist any longer than absolutely necessary. I'll plan to move whatever's left of the things that shouldn't exist to repro data in ~a week.

@campmlc
Copy link

campmlc commented Sep 6, 2024

Gonad length and gonad width should exist, correct? We don't want to get rid of them. We are trying to move all applicable data out of reproductive data as part of this process.
I will convert all ANSP data including what is pending in the loaders to gonad length and gonad width.
Ah, I understand your comment. Yes, agree.

@jrpletch
Copy link

jrpletch commented Sep 6, 2024

OWU's should be all fixed

@campmlc
Copy link

campmlc commented Sep 6, 2024

ANSP gonads are deleted; converted gonad length and width attributes loading now

@campmlc
Copy link

campmlc commented Sep 10, 2024

all ANSP should be fixed.

@bryansmclean
Copy link

gonads are deleted

If someone outside Arctos knew the kinds of things that were going on here...

@dustymc
Copy link
Contributor Author

dustymc commented Oct 3, 2024

AWG issues meeting - this is all approved and can be migrated, DLM will figure it out and leave any data that changes. Try to get the bulkloader too.

@dustymc
Copy link
Contributor Author

dustymc commented Oct 3, 2024

TODO: Check documentation, some confusion over method vs. remarks for left/right/etc. (Consensus on method, I think.)

@dustymc
Copy link
Contributor Author

dustymc commented Oct 3, 2024

gonad was used one time for https://arctos.database.museum/guid/MLZ:Bird:69262, manually updated

@dustymc
Copy link
Contributor Author

dustymc commented Oct 3, 2024

right gonad width

EDIT: I'm going with @adhornsby 's plan from #7504 (comment) - probably most people guess definitions from terms, the remarks should make everything clear, and my original plan would lose datatype and make recovery more difficult. Moving on to reproductive data from here will be easy if anyone wants to do so, just let me know.

Note that this is defined as "Length measurement of the left gonad." and I'm very hesitant to do anything more precise than what's proposed below from a 3-way mess.

Data:

temp_rgw.csv.zip

Summary:


 guid_prefix | count 
-------------+-------
 UMNH:Mamm   |     1
 BYU:Bird    |   465
 UCSC:Mamm   |     1
 MVZ:Mamm    |    22
 UNR:Mamm    |     1
 MMNH:Bird   |    18
 MMNH:Mamm   |     1
 MVZ:Herp    |    40
 HSUVM:Mamm  |     7
 KSB:Mamm    |     1
 UAM:Mamm    |     1
 UMZM:Bird   |    22
 UMNH:Bird   |     8
 MLZ:Bird    |     9
 UMZM:Mamm   |    23
 UCM:Bird    |    47

Users:

@amgunderson
@adhornsby
@mkoo
@cjconroy
@atrox10
@ebraker
@kderieg322079
@asemerdj
@byuherpetology

I will plan to move this to reproductive data [ link ] with "Formerly right gonad width, which was defined as Length measurement of the left gonad." appended to remark unless someone shows up with a better plan before ~early next week.

@dustymc
Copy link
Contributor Author

dustymc commented Oct 3, 2024

right gonad length

Data:

temp_rgl.csv.zip

Summary:


 guid_prefix | count 
-------------+-------
 UMNH:Mamm   |     2
 BYU:Bird    |   465
 UCSC:Mamm   |     1
 MVZ:Mamm    |    22
 UNR:Mamm    |     1
 MMNH:Bird   |    18
 UTEP:Bird   |     1
 MMNH:Mamm   |     1
 MVZ:Herp    |   177
 HSUVM:Mamm  |     7
 UAM:Mamm    |     1
 UMZM:Bird   |    22
 UMNH:Bird   |     5
 UWBM:Mamm   |    85
 MLZ:Bird    |     9
 UMZM:Mamm   |    23
 UCM:Bird    |    47

contact

@amgunderson
@adhornsby
@mkoo
@cjconroy
@atrox10
@jebrad
@mvzhuang
@ebraker
@kderieg322079
@asemerdj
@byuherpetology

I'll update to gonad length [ link ] and append 'right gonad length' to method unless someone shows up with a better plan before ~early next week.

@dustymc
Copy link
Contributor Author

dustymc commented Oct 3, 2024

left gonad length

data

temp_lgl.csv.zip

summary

 guid_prefix | count 
-------------+-------
 UNR:Mamm    |     2
 MMNH:Bird   |    37
 MVZ:Herp    |   153
 HSUVM:Mamm  |     7
 APSU:Bird   |   112
 MLZ:Bird    |   217
 UMZM:Mamm   |    21
 UCM:Bird    |    50
 UMNH:Mamm   |     1
 UCSC:Mamm   |     4
 UTEP:Bird   |     2
 KSB:Mamm    |   308
 UMZM:Bird   |    44
 UMNH:Bird   |    10
 MSB:Mamm    |     2
 UWBM:Mamm   |   111
 OWU:Bird    |     1
 BYU:Bird    |   510

users

@ebraker
@byuherpetology
@mkoo
@campmlc
@kderieg322079
@atrox10
@mvzhuang
@asemerdj
@adhornsby
@jebrad
@gradyjt
@jrpletch
@AdrienneRaniszewski
@jldunnum

I'll update to gonad length [ link ] and append 'left gonad length' to method unless someone shows up with a better plan before ~early next week.

@dustymc
Copy link
Contributor Author

dustymc commented Oct 3, 2024

left gonad width

data

temp_lgw.csv.zip

summary


 guid_prefix | count 
-------------+-------
 UNR:Mamm    |     2
 MMNH:Bird   |    37
 MVZ:Herp    |    62
 HSUVM:Mamm  |     7
 APSU:Bird   |   112
 MLZ:Bird    |   218
 UMZM:Mamm   |    21
 UCM:Bird    |    49
 UMNH:Mamm   |     1
 UCSC:Mamm   |     4
 UTEP:Bird   |     1
 KSB:Mamm    |   303
 UMZM:Bird   |    44
 UMNH:Bird   |     7
 BYU:Bird    |   510

users

@ebraker
@byuherpetology
@mkoo
@kderieg322079
@atrox10
@mvzhuang
@asemerdj
@adhornsby
@gradyjt

I'll update to gonad width [ link ] and append 'left gonad width' to method unless someone shows up with a better plan before ~early next week.

@adhornsby
Copy link

For all MMNH & UMZM:
Instead of having 'right gonad width' sent to reproductive data, can I have it handled like the other traits -- i.e. updated to 'gonad width' with method 'right gonad width.' I know we were using that trait at face value, so the old mismatched definition in the table doesn't bother me.

MMNH & UMZM are otherwise good to be updated as planned.

@dustymc
Copy link
Contributor Author

dustymc commented Oct 7, 2024

@adhornsby sure and thanks!

@amgunderson
@mkoo
@cjconroy
@atrox10
@ebraker
@kderieg322079
@asemerdj
@byuherpetology

would you like to make any adjustments to #7504 (comment)?

@cjconroy
Copy link

cjconroy commented Oct 7, 2024

Fine with MVZ mammals. I added this info to reproductive data, so there would be something like verbatim data as well.

@dustymc
Copy link
Contributor Author

dustymc commented Oct 9, 2024

@dustymc dustymc closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants