Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Table Request - add 'preps unfinished' to accn status #5375

Closed
ccicero opened this issue Dec 15, 2022 · 34 comments
Closed

Code Table Request - add 'preps unfinished' to accn status #5375

ccicero opened this issue Dec 15, 2022 · 34 comments
Labels
Function-CodeTables Priority-High (Needed for work) High because this is causing a delay in important collection work..

Comments

@ccicero
Copy link

ccicero commented Dec 15, 2022

Goal
To make it easier to use Arctos to track the status of different accessions.

Context
-- Accession_status currently has the following values: 'in process' 'ready to catalog' 'complete'.
-- 'ready to catalog' and 'complete' are self explanatory, but 'in process' can mean lots of different things - e.g., in process of acquisition, in process of preparation, OR in process of cataloging.
-- We currently use Google docs to track accessions where specimens are not fully prepared. Either they're in a freezer or they're in process of preparation. It will greatly streamline curatorial workflow if we can use Arctos for that purpose. We do not catalog items in an accession until everything for that accession has been prepared, so we need to know which accessions have unfinished preps. Once all preps are done, then the accession is 'ready to catalog'

Table
https://arctos.database.museum/info/ctDocumentation.cfm?table=ctaccn_status

Proposed Value
'preps unfinished'

Proposed Definition
Preparations have not be completed for this accession. Items may either be in a freezer or other container awaiting preparation, or they may be in various stages of preparation.'

@ccicero ccicero added Priority-High (Needed for work) High because this is causing a delay in important collection work.. Function-CodeTables labels Dec 15, 2022
@dustymc
Copy link
Contributor

dustymc commented Dec 15, 2022

I don't think there's anything functional about those values (in the code, they're clearly functional to humans), this isn't a different way of saying something else - goferit.

in process could probably be clarified at the same time, but I'm not sure what to suggest. "General-puurpose status of not being complete'??

@dustymc dustymc added this to the Needs Discussion milestone Dec 15, 2022
@ewommack
Copy link

this isn't a different way of saying something else - goferit

I agree with Dusty here.
"Preps unfinished" seems like a subsection of "In Process" though. Would it be more usable for multiple types of collections to create subsets of "In Process"?
"In Process of acquisition"
"In Process of preparation"
"In Process of cataloging"
"In Process of installation"

@campmlc
Copy link

campmlc commented Dec 15, 2022

I like @ewommack 's suggestion.

@ccicero
Copy link
Author

ccicero commented Dec 15, 2022

I like that too! However, how do we migrate the ones currently 'in process' to one of those options? Can we add those values to the CT but we probably also need to keep 'in process' or change it to something generic ???

@dustymc
Copy link
Contributor

dustymc commented Dec 15, 2022

how do we migrate the ones currently 'in process' to one of those options

You can't, and the documentation should make it clear that plain ol' in process is outside of any more-specific path/workflow/status; it encompasses all of the more-specific states, however vaguely.

Also lose the Proper Case please - "in process of acquisition" etc.

@ccicero
Copy link
Author

ccicero commented Dec 15, 2022

+1

@ewommack
Copy link

Also lose the Proper Case please - "in process of acquisition" etc.

"in process"
"in process of acquisition"
"in process of preparation"
"in process of cataloging"
"in process of installation"
@dustymc - better?

Since I was trying to think of all collections types @AJLinn @Nicole-Ridgwell-NMMNHS - anything else you guys have for processing?

@ccicero
Copy link
Author

ccicero commented Dec 15, 2022

Draft definitions (I used 'components' per our CT discussion 12/15/2022, but that's negotiable although it would be good to use consistent terminology):

-- in process - "This accession is a work in progress, but its exact status is unknown." (slightly expanded from current)
-- in process of acquisition - "Steps have been taken to acquire this accession, but not all components and/or documentation are in hand. Example: Components are accessioned but the collection is still waiting on more items or on data, permits, or other documentation."
-- in process of preparation - "Preparation of components pertaining to this accession is incomplete. Components may be in a freezer awaiting preparation or they may be in various stages of preparation (e.g., specimen is skinned but not stuffed)."
-- in process of cataloging - "Components pertaining to this accession are in the process of being assigned catalog numbers or of being labeled or numbered. This status typically precedes installation."
-- in process of installation - "Components pertaining to this accession are in the process of being moved to where they belong in the collection."
ready to catalog- "All components pertaining to this accession are ready to be assigned catalog numbers." (slightly modified from current)
complete - "All components and information pertaining to the accession are where they belong. Components have been installed into the collection." (slightly modified from current)

@Jegelewicz
Copy link
Member

Jegelewicz commented Dec 15, 2022

It looks like we might need a few intermediate steps - how about this?

Term definition
in process This accession is a work in progress, but its exact status is unknown. Use more specific statuses if possible.
in process of acquisition Steps have been taken to acquire this accession, but not all components and/or documentation are in hand. Example: Components are accessioned but the collection is still waiting on more items or on data, permits, or other documentation.
ready for preparation All components pertaining to this accession are ready for preparation.
in process of preparation Preparation of components pertaining to this accession is incomplete. Example: Components may be in a freezer awaiting preparation or they may be in various stages of preparation (e.g., specimen is skinned but not stuffed).
ready to catalog All components pertaining to this accession are ready to be assigned catalog numbers and labeled.
in process of cataloging Components pertaining to this accession are in the process of being assigned catalog numbers or of being labeled or numbered. This status typically precedes installation.
ready to install All components pertaining to this accession are ready to be moved to where they belong in the collection.
in process of installation Components pertaining to this accession are in the process of being moved to where they belong in the collection.
complete All components and information pertaining to the accession are where they belong. Components have been installed into the collection.

@ccicero
Copy link
Author

ccicero commented Dec 15, 2022

I think we can merge 'ready for preparation' and 'in process of preparation' and tweak the definition - basically, are all the items prepared or not? I suggest combining into something that's a version of what I originally suggested:

preparation incomplete - "All components pertaining to this accession are ready for preparation but preparation is not completed. Components may be in a freezer awaiting preparation or they may be in various stages of preparation (e.g., specimen is skinned but not stuffed)." (I actually like that better than 'in process of preparation' because carcasses sitting in a freezer are not in process)

The rest looks good to me, and I think will be super helpful.

I'm also thinking it would be useful to have these terms ordered (in the dropdown) sequentially in terms of steps in the process versus alphabetically. @dustymc is that feasible?

in process of acquisition
preparation incomplete
ready to catalog
in process of cataloging
ready to install
in process of installation
complete

@dustymc
Copy link
Contributor

dustymc commented Dec 16, 2022

ordered (in the dropdown) sequentially

It's not magic but it would mean one thing's different than all the rest, and that'll eventually find a way to be weird. Any reason not to prefix with numbers/letters so they'll sort natively?

@ccicero
Copy link
Author

ccicero commented Dec 16, 2022

No reason not to prefix with a number. Will others find that useful and more sensical than alphabetical which would look like:

complete
in process of acquisition
in process of cataloging
in process of installation
preparation incomplete
ready to catalog
ready to install

NEW TERMS IN ORDER:
1-in process of acquisition
2-preparation incomplete
3-ready to catalog
4-in process of cataloging
5-ready to install
6-in process of installation
7-complete

@Jegelewicz
Copy link
Member

Term definition
in process This accession is a work in progress, but its exact status is unknown. Use more specific statuses if possible.
1-in process of acquisition Steps have been taken to acquire this accession, but not all components and/or documentation are in hand. Example: Components are accessioned but the collection is still waiting on more items or on data, permits, or other documentation.
2-preparation incomplete All components pertaining to this accession are ready for preparation but preparation is not completed. Components may be in a freezer awaiting preparation or they may be in various stages of preparation. Example: specimen is skinned but not stuffed.
3-ready to catalog All components pertaining to this accession are ready to be assigned catalog numbers and labeled.
4-in process of cataloging Components pertaining to this accession are in the process of being assigned catalog numbers or of being labeled or numbered. This status typically precedes installation.
5-ready to install All components pertaining to this accession are ready to be moved to where they belong in the collection.
6-in process of installation Components pertaining to this accession are in the process of being moved to where they belong in the collection.
7-complete All components and information pertaining to the accession are where they belong. Components have been installed into the collection.

@campmlc
Copy link

campmlc commented Dec 16, 2022 via email

@wellerjes
Copy link

Thoughts on changing "install" to "integrate"? When I hear "install" or "installation", I think of installing it in an exhibit, not putting it away in our collections.

@ewommack
Copy link

When I hear "install" or "installation", I think of installing it in an exhibit, not putting it away in our collections.

Can you do both for an accession? The definition is pretty broad, and wouldn't some accessions go from prep into an exhibit or into the cases depending on their intended use?

@ccicero
Copy link
Author

ccicero commented Dec 16, 2022

+1 to what @ewommack wrote. 'Install' can mean both things, so I think we just need to update the definition. When I hear 'integrate' I don't think of putting something away in the collection (for example, specimens from one accession are received at different times; each time material is received, it's integrated with the rest of that accession but not yet cataloged)

Suggested updates:

5-ready to install: All components pertaining to this accession are ready to be moved to where they belong in the collection or exhibit.

6-in process of installation: Components pertaining to this accession are in the process of being moved to where they belong in the collection or exhibit.

@ccicero
Copy link
Author

ccicero commented Dec 20, 2022

Can we finalize these additions to the CT and their definitions? I'd like to start using this asap.

@jldunnum
Copy link

When I look through the various stages I think we would probably only be able use "in process" and "complete". Once we have acquired an accession we don't process the whole accession in complete steps. For example, we may digitally catalog the entire accession first, then prepare and install some subset before doing anything with the rest of the specimens. Basically we could have parts of an accession at every level of the process.
In regard to number 1 - would you assign an accession number before you've fully acquired it? I think of accessioning as the act of taking legal responsibility for the collection or object in question. We wouldn't do that if it didn't have all the proper documentation ahead of time.

@ccicero
Copy link
Author

ccicero commented Dec 20, 2022

@jldunnum I think this system will allow different collections to use whatever steps make sense for them in tracking accession status. We don't catalog bird accessions until all specimens have been fully prepped, but other collections may do something similar to what you do.

I could see using #1 for (e.g.) archival or observational accessions where permits are not the issue. Sometimes we acquire archival accessions - e.g., field notes - in stages and keep the accession open. Likewise, we may accession a set of observational records while we're still waiting on some information. There are also cases where we will accession a set of specimens but still need some documentation (although that's less common).

@jldunnum
Copy link

jldunnum commented Dec 21, 2022 via email

@Jegelewicz
Copy link
Member

Jegelewicz commented Dec 21, 2022

I have some concerns about the numbering which is MVZ's workflow, but not necessarily everyone else's. I suggest that the order of completion should come from a workflow held by the institution. This can be recorded in Github (see what @Nicole-Ridgwell-NMMNHS is doing with cabinet inventories and place creation - https://github.com/ArctosDB/Arctos-Workflows/issues). I suggest the terms be added as follows:

Term definition
in process This accession is a work in progress, but its exact status is unknown. Use more specific statuses if possible.
in process of acquisition Steps have been taken to acquire this accession, but not all components and/or documentation are in hand. Example: Components are accessioned but the collection is still waiting on more items or on data, permits, or other documentation.
preparation incomplete All components pertaining to this accession are ready for preparation but preparation is not completed. Components may be in a freezer or field jacket awaiting preparation or they may be in various stages of preparation. Example: Specimen is skinned but not stuffed.
ready to catalog All components pertaining to this accession are ready to be assigned catalog numbers and labeled.
in process of cataloging Components pertaining to this accession are in the process of being assigned catalog numbers or of being labeled or numbered. This status typically precedes installation.
ready to install All components pertaining to this accession are ready to be moved to where they belong in the collection.
in process of installation Components pertaining to this accession are in the process of being moved to where they belong in the collection.
complete All components and information pertaining to the accession are where they belong. Components have been installed into the collection.

@ccicero
Copy link
Author

ccicero commented Dec 21, 2022

I'm fine removing the numbers but other than that, what is different here? If we enter them without numbers, they'll just sort alphabetically - correct? That's fine with me, order is less important than having the different options for status.

Can we move forward with this?

@Jegelewicz
Copy link
Member

If we enter them without numbers, they'll just sort alphabetically - correct?

Yep

Can we move forward with this?

No objection from me.

@Nicole-Ridgwell-NMMNHS
Copy link

I think this is great! I just have one small suggested change for the preparation definition:

All components pertaining to this accession are ready for preparation but preparation is not completed. Components may be in a freezer or field jacket awaiting preparation or they may be in various stages of preparation. Example: Specimen is skinned but not stuffed.

@Jegelewicz
Copy link
Member

Added above to #5375 (comment)

@ewommack
Copy link

Looks good to me.

I now want stickers for when I finish different stages....

@ccicero
Copy link
Author

ccicero commented Jan 5, 2023

I plan to add these terms to the CT today, so let me know if there are any final comments/changes. Thanks.

@ccicero
Copy link
Author

ccicero commented Jan 9, 2023

@dustymc I'm working on adding these terms but am running into a 20 character limit. Can you please increase the character limit (30 characters)? Thanks.

@ccicero
Copy link
Author

ccicero commented Jan 10, 2023

@dustymc not sure if you saw this but can you fix it so I can add these values to the CT? Thanks!

@dustymc
Copy link
Contributor

dustymc commented Jan 10, 2023

Done.

@ccicero
Copy link
Author

ccicero commented Jan 10, 2023

@dustymc Did you make the change in test or prod? I'm still getting an error in prod:

ERROR_MESSAGE: value too long for type character varying(20) Where: SQL statement "insert into log_CTACCN_STATUS( username, change_date, n_ACCN_STATUS, n_DESCRIPTION, o_ACCN_STATUS, o_DESCRIPTION ) values ( session_user, LOCALTIMESTAMP, NEW.ACCN_STATUS, NEW.DESCRIPTION, OLD.ACCN_STATUS, OLD.DESCRIPTION )" PL/pgSQL function trigger_fct_tr_log_ctaccn_status() line 3 at SQL statement

ERROR_SQL: INSERT INTO ctaccn_status (accn_status ,description ) VALUES ('in process of acquisition' ,'Steps have been taken to acquire this accession, but not all components and/or documentation are in hand. Example: Components are accessioned but the collection is still waiting on more items or on data, permits, or other documentation.' )

@dustymc
Copy link
Contributor

dustymc commented Jan 10, 2023

Oh, I missed the log table, try again.

@ccicero
Copy link
Author

ccicero commented Jan 13, 2023

Worked, thanks! Values added to ctaccn_status_ 13 Jan 2023.

@ccicero ccicero closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Function-CodeTables Priority-High (Needed for work) High because this is causing a delay in important collection work..
Projects
None yet
Development

No branches or pull requests

8 participants