Set heartbeat autopilot correctly #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soren Friis <soren.friis@intel.com>
According to the documentation, components that are not autopilots, should set the heartbeat autopilot field to MAV_AUTOPILOT_INVALID. https://mavlink.io/en/services/heartbeat.html#component-identity Signed-off-by: Soren Friis <soren.friis@intel.com>
|
@tridge: Could you please review and possibly merge? |
tridge
approved these changes
Sep 15, 2022
|
sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update the build dependencies.
For some reason, installing python3 pyserial was good enough for me to get the compile process completed but not enough for the upload part. I needed also python pyserial for that. It could just be my old Ubuntu installation, which has gotten messed up over time so I only added a comment about the latter to the build instructions.
BTW: I have also noticed that
make setupwill fail if you are behind a proxy server (not surprisingly since it is trying to download a bunch of things). What surprised me was that also the puremakewill occasionally fail (I don't know why that wants to access the internet). This is probably something inside the Arduino tools. I didn't try to start fighting with this but turned off the VPN on my home machine (wouldn't be an option for the machine in the office though).