Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WLAN beacon implementation #67

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Conversation

BluemarkInnovations
Copy link
Contributor

@BluemarkInnovations BluemarkInnovations commented Sep 21, 2022

First PR of the WLAN Beacon implementation.

  • Beacon functionality only works if also WLAN NaN is enabled (and the web interface). Needs more testing, it seems that without WLAN NaN, the module uses channel 1 and the PR doesn't work.
  • Need improvement, so the module transmits also WLAN Beacon packets if the web interface is disabled.
  • The Beacon update rate means that the RID information is updated with this rate. Default an AP transmits every 100 ms a Beacon packet.
  • Added the probe response implementation. This is the default mechanism (probe request/response) for smartphones to detect nearby APs. Without the probe-response implementation, the user experience/update rate is horrible on most phones. With the probe response implementation and on the smartphone, WiFi scanning throttling off (Developer options, see the OpenDroneID project), performance is acceptable.

FYI @friissoren

@BluemarkInnovations BluemarkInnovations changed the title Wlan beacon WLAN beacon implementation Sep 21, 2022
@BluemarkInnovations
Copy link
Contributor Author

Fixed outstanding issues

RemoteIDModule/WiFi_TX.cpp Outdated Show resolved Hide resolved
RemoteIDModule/WiFi_TX.cpp Outdated Show resolved Hide resolved
@BluemarkInnovations
Copy link
Contributor Author

  • made the wifi channel a parameter
  • code clean up, some calls were not needed
  • the issue/bug was that the web server did have its own default configuration values, not using the configured ones, solved in this PR
  • use the random generated MAC address also for WLAN packet generation instead of the device MAC address
  • added separate counters for both beacon and NaN packets

@tridge
Copy link
Contributor

tridge commented Oct 14, 2022

squashed commits

max 15 chars parameter names
allow WiFi to totally disable
@tridge tridge merged commit e1684b8 into ArduPilot:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants