mavgen_java.py: generate_enums: assume all integers to be 64 bits #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jillh54 FYI. |
|
@peterbarker is this something you can review? Thanks in advance! |
magicrub
approved these changes
Mar 30, 2022
|
This change breaks everybody's Java code and forces a int cast to the command enum when using it in a command. The large values are related to masks. The longs should only be used for masks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #638. Though I wonder if it is acceptable to use a larger data struct by default to enums just because of a single enumeration. Anyway we might eventually have other cases where this will happen.