Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add metadata to Java MAVLink message class fields #694

Conversation

rrr6399
Copy link
Contributor

@rrr6399 rrr6399 commented Jun 22, 2022

This is a pull request that just adds a Units and Description annotation to the MAVLink message classes for Java so that they can be retrieved at runtime for plotting and such similar to the C# class generator.

This one does not have a merge in the history and I'm closing this pull request:
#636

@rrr6399
Copy link
Contributor Author

rrr6399 commented Jun 22, 2022

@amilcarlucas Let me know if you need anything else done on this pull request to allow it to be merged.

@amilcarlucas
Copy link
Contributor

Please remove the whitespaces changes
Please add a comment near the units explaining where the original pymavlink units are defined and found.

@rrr6399
Copy link
Contributor Author

rrr6399 commented Jun 24, 2022

@amilcarlucas

Please add a comment near the units explaining where the original pymavlink units are defined and found.

Good suggestion. Let me know if the descriptions I added are sufficient.

@amilcarlucas
Copy link
Contributor

This is starting to look really good to me, but I am no Java programmer.

@rrr6399
Copy link
Contributor Author

rrr6399 commented Jun 24, 2022

@amilcarlucas I may be one of the few programmers using Java for MAVLink processing. The annotations won't impact anybody's parser's performance. They just add metadata so that plotting packages and such can use them for user-friendly displays similar to what MissionPlanner does with them. Would you be able to merge this?

@amilcarlucas
Copy link
Contributor

Can you squash the commits so that "git blame" works like it should?

rrr6399 added 4 commits June 24, 2022 19:59
Add annotations for Units and Descriptions to each payload field of the MAVLink messages for Java

Remove spurious whitespaces

Get rid of more spurious whitespaces

Add overview descriptions to classes with pointers to the MAVLink units specification
…ds-v2' of https://github.com/rrr6399/pymavlink into feature/feature/add-metadata-to-java-mavlink-class-fields-v2
Add annotations for Units and Descriptions to each payload field of the MAVLink messages for Java

Remove spurious whitespaces

Get rid of more spurious whitespaces

Add overview descriptions to classes with pointers to the MAVLink units specification
…ds-v2' of https://github.com/rrr6399/pymavlink into feature/feature/add-metadata-to-java-mavlink-class-fields-v2
@rrr6399
Copy link
Contributor Author

rrr6399 commented Jun 25, 2022

@amilcarlucas Can you squash it on merge? I tried squashing on rebase, but a commit from the master snuck in on my branch and screwed up the history again when I tried to fix it. I tried squashing on merge locally and it appears to work OK.

@rrr6399 rrr6399 changed the title Feature/add metadata to Java MAVLink message class fields - Try 2 Feature/add metadata to Java MAVLink message class fields Jul 9, 2022
@rrr6399
Copy link
Contributor Author

rrr6399 commented Jul 13, 2022

@amilcarlucas @tridge Can this be merged before it becomes stale again? Thanks!

@amilcarlucas amilcarlucas merged commit fd83f66 into ArduPilot:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants