-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add metadata to Java MAVLink message class fields #694
Feature/add metadata to Java MAVLink message class fields #694
Conversation
@amilcarlucas Let me know if you need anything else done on this pull request to allow it to be merged. |
Please remove the whitespaces changes |
Good suggestion. Let me know if the descriptions I added are sufficient. |
This is starting to look really good to me, but I am no Java programmer. |
@amilcarlucas I may be one of the few programmers using Java for MAVLink processing. The annotations won't impact anybody's parser's performance. They just add metadata so that plotting packages and such can use them for user-friendly displays similar to what MissionPlanner does with them. Would you be able to merge this? |
Can you squash the commits so that "git blame" works like it should? |
Add annotations for Units and Descriptions to each payload field of the MAVLink messages for Java Remove spurious whitespaces Get rid of more spurious whitespaces Add overview descriptions to classes with pointers to the MAVLink units specification
…ds-v2' of https://github.com/rrr6399/pymavlink into feature/feature/add-metadata-to-java-mavlink-class-fields-v2
Add annotations for Units and Descriptions to each payload field of the MAVLink messages for Java Remove spurious whitespaces Get rid of more spurious whitespaces Add overview descriptions to classes with pointers to the MAVLink units specification
…ds-v2' of https://github.com/rrr6399/pymavlink into feature/feature/add-metadata-to-java-mavlink-class-fields-v2
@amilcarlucas Can you squash it on merge? I tried squashing on rebase, but a commit from the master snuck in on my branch and screwed up the history again when I tried to fix it. I tried squashing on merge locally and it appears to work OK. |
@amilcarlucas @tridge Can this be merged before it becomes stale again? Thanks! |
This is a pull request that just adds a Units and Description annotation to the MAVLink message classes for Java so that they can be retrieved at runtime for plotting and such similar to the C# class generator.
This one does not have a merge in the history and I'm closing this pull request:
#636