Make the mavfft_isb accessible to other programs #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
approved these changes
Jul 23, 2022
|
Yeah, sorry the diff is horrendous. Basically moved the function into a class. Made all of the args variables withing that class then added a main == name check and moved the arg parser after that. Tested all args and all are working as before. |
Hiding whitespace changes makes it much more palatable. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mavfft_isb is a pretty useful tool. I like to use it as part of other tools. I also wanted to integrate it into the MavExplorer partly to add the functionality of this tool into MavExplorer and to reduce duplication. This PR will enable that.
Functionality should be unchanged so it can be used as it was for everyone that used it previously.