migrate CI node from 12 to 16 as 12 is deprecated #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbuzz
force-pushed
the
pr-node-16
branch
5 times, most recently
from
c93591d to
8748c62
Compare
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ also makes the the pretest/s explicit, as there's a bit of recursion in the old tests that needed to go away.
davidbuzz
force-pushed
the
pr-node-16
branch
from
8748c62 to
8523524
Compare
|
there also used to be some recursion in the tests... "npm test" triggered a "pretest" action that would run ./test_gen_js.sh BEFORE the mocha tests, but with a bump in Node version, that no longer worked in CI, so i disabled the pretest and explicitly run it in test.yml first/before the mocha tests. its cleaner this way and more obvious. |
|
@hamishwillee , @peterbarker @tridge - jut smamming anyone who might want to click merge... ? |
|
I don't have merge permissions - sorry! |
tridge
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/