Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for relative path to generated lua mavlink module #791

Closed

Conversation

bugobliterator
Copy link
Member

No description provided.

@rotu
Copy link
Contributor

rotu commented May 15, 2023

What's the deal with this PR? It looks like it was cherry-picked in? aba3c41

Also, while we're at it, why do both Lua and WLua exist, and why is Lua omitted from the tests?

https://github.com/ArduPilot/pymavlink/blob/e4eb7fab82a3a342f98535cbf168bf5ed82174f2/test_generate_all.sh

@bugobliterator
Copy link
Member Author

bugobliterator commented May 15, 2023

What's the deal with this PR? It looks like it was cherry-picked in? aba3c41

Also, while we're at it, why do both Lua and WLua exist, and why is Lua omitted from the tests?

https://github.com/ArduPilot/pymavlink/blob/e4eb7fab82a3a342f98535cbf168bf5ed82174f2/test_generate_all.sh

This is for ardupilot lua script generation. The Lua needs to be added to that list.

@rotu
Copy link
Contributor

rotu commented May 15, 2023

This is for ardupilot lua script generation. The Lua needs to be added to that list.

Makes sense. Probably could also document how to use the generated files and remove this misleading comment:

parse a MAVLink protocol XML file and generate a Wireshark LUA dissector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants