mavlogdump: Use sys.exit instead of quit on error #930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @peterbarker pointed out in comments on #928, quit() should not be normally be used in scripts, but instead sys.exit() is preferred.
This PR replaces the uses of quit() and exit() in mavlogdump with sys.exit(1) - all uses are error conditions, hence using return code 1.
I tested a few of the error conditions out, and checked they return neatly with the correct error code set, for example: