DFReader.py: emit enumeration value name when verbose-dumping #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shancock884
suggested changes
Jul 3, 2024
DFReader.py
Outdated
| enum_entry_name = entry.get('name') | ||
| break | ||
|
|
||
| f.write(f" {enum_entry_name}") |
There was a problem hiding this comment.
Suggested change
| f.write(f" {enum_entry_name}") | |
| f.write(f" ({enum_entry_name})") |
Maybe brackets around the enum entry name for consistency with what is done for tlogs.
There was a problem hiding this comment.
Cool. I was going backwards and forwards on this, so I'll make the change.
peterbarker
force-pushed
the
pr/dfreader-dump-enum-entry-name
branch
from
fba84fc to
b287f4f
Compare
|
Merged this, thanks @shancock884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shancock884
(we don't emit the mode enumerations into the ArduPilot metadata yet)