Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFReader: In dump verbose show hex value for bitmask fields #996

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

shancock884
Copy link
Contributor

The aim of this PR is to add the hex value alongside the decimal value, when displaying bitmask fields with the "dump --verbose" command in MavExplorer, as I think it is easier to follow which bits are set in hex.

This is also more in-line with how bitmasks are shown from TLog files when using "dump --verbose".

For example, on XKF4:

> dump --verbose XKF4
2024-12-04 14:53:37.722: XKF4
    ...
    SS: 107327 (0x1a33f)
        ATTITUDE (attitude estimate valid)
        HORIZ_VEL (horizontal velocity estimate valid)
        VERT_VEL (vertical velocity estimate valid)
    ...

Tested locally with a variety of messages containing bitmasks.

@peterbarker peterbarker merged commit c06935e into ArduPilot:master Dec 7, 2024
14 checks passed
@peterbarker
Copy link
Contributor

... eg. 0b01011101 would seem to be better still for your goal..

@shancock884 shancock884 deleted the bitmask-value-hex branch December 8, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants