Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to run feature modules independent from main app module #247

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

sergevalevich
Copy link

This allows Instant App support [https://github.com//issues/209)],
running unit-tests for feature modules [https://github.com//issues/223]
and other issues [https://github.com//issues/224].

Here, Moxy always references to MoxyReflector by com.arellomobile.mvp package and generates
MoxyReflectorDelegate for each module.

In order to use Moxy, there is no need to follow instructions described on this page https://github.com/Arello-Mobile/Moxy/wiki/Multiple-modules

Now it is only required to add 1 line of code to each module's BaseActivity.onCreate, or App.onCreate or any place where feature module gets initialized : MoxyReflector.registerDelegate(MoxyReflectorDelegate.INSTANCE);

vova and others added 30 commits May 25, 2018 13:40
 Merge pull request Arello-Mobile#189 from AlexeyKorshun/develop
…ized-view

Fix types of parameters in methods from generic superinterfaces
@sergevalevich
Copy link
Author

Usage example for modules, which declare Application class:

class MyApp: Application() {
    override fun onCreate() {
        super.onCreate()
        MoxyReflector.registerDelegate(MoxyReflectorDelegate.INSTANCE)
    }
}

Usage example for library modules, which don't have Application class:

class MyModuleBaseActivity: MvpAppCompatActivity() {
    override fun onCreate() {
        super.onCreate()
        MoxyReflector.registerDelegate(MoxyReflectorDelegate.INSTANCE)
    }
}

VovaStelmashchuk and others added 8 commits March 5, 2019 11:30
…n module.

This allows Instant App support (Arello-Mobile#209),
running unit-tests for feature modules (Arello-Mobile#223)
and other issues Arello-Mobile#224.

Here, Moxy always references to MoxyReflector by com.arellomobile.mvp package and generates
MoxyReflectorDelegate for each module.

In order to use Moxy, there is no need to follow instructions described on this page https://github.com/Arello-Mobile/Moxy/wiki/Multiple-modules

Now it is only required to add 1 line of code to BaseActivity.onCreate of each module : MoxyReflector.registerDelegate(MoxyReflectorDelegate.INSTANCE);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants