Issue primefaces#12734

+ Use of this.document instead direct document
Arematics · Mar 11, 2023 · 514e9f7 · 514e9f7
1 parent 6a49b94
commit 514e9f7
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 23 deletions.
diff --git a/src/app/components/button/button.ts b/src/app/components/button/button.ts
@@ -118,21 +118,21 @@ export class ButtonDirective implements AfterViewInit, OnDestroy {
 
     createLabel() {
         if (this.label) {
-            let labelElement = document.createElement('span');
+            let labelElement = this.document.createElement('span');
             if (this.icon && !this.label) {
                 labelElement.setAttribute('aria-hidden', 'true');
             }
 
             labelElement.className = 'p-button-label';
-            labelElement.appendChild(document.createTextNode(this.label));
+            labelElement.appendChild(this.document.createTextNode(this.label));
 
             this.htmlElement.appendChild(labelElement);
         }
     }
 
     createIcon() {
         if (this.icon || this.loading) {
-            let iconElement = document.createElement('span');
+            let iconElement = this.document.createElement('span');
             iconElement.className = 'p-button-icon';
             iconElement.setAttribute('aria-hidden', 'true');
             let iconPosClass = this.label ? 'p-button-icon-' + this.iconPos : null;

diff --git a/src/app/components/confirmdialog/confirmdialog.ts b/src/app/components/confirmdialog/confirmdialog.ts
@@ -375,7 +375,7 @@ export class ConfirmDialog implements AfterContentInit, OnInit, OnDestroy {
 
     appendContainer() {
         if (this.appendTo) {
-            if (this.appendTo === 'body') document.body.appendChild(this.wrapper);
+            if (this.appendTo === 'body') this.document.body.appendChild(this.wrapper);
             else DomHandler.appendChild(this.wrapper, this.appendTo);
         }
     }
@@ -388,7 +388,7 @@ export class ConfirmDialog implements AfterContentInit, OnInit, OnDestroy {
 
     enableModality() {
         if (this.option('blockScroll')) {
-            DomHandler.addClass(document.body, 'p-overflow-hidden');
+            DomHandler.addClass(this.document.body, 'p-overflow-hidden');
         }
 
         if (this.option('dismissableMask')) {
@@ -404,7 +404,7 @@ export class ConfirmDialog implements AfterContentInit, OnInit, OnDestroy {
         this.maskVisible = false;
 
         if (this.option('blockScroll')) {
-            DomHandler.removeClass(document.body, 'p-overflow-hidden');
+            DomHandler.removeClass(this.document.body, 'p-overflow-hidden');
         }
 
         if (this.dismissableMask) {
@@ -418,9 +418,9 @@ export class ConfirmDialog implements AfterContentInit, OnInit, OnDestroy {
 
     createStyle() {
         if (!this.styleElement) {
-            this.styleElement = document.createElement('style');
+            this.styleElement = this.document.createElement('style');
             this.styleElement.type = 'text/css';
-            document.head.appendChild(this.styleElement);
+            this.document.head.appendChild(this.styleElement);
             let innerHTML = '';
             for (let breakpoint in this.breakpoints) {
                 innerHTML += `
@@ -534,7 +534,7 @@ export class ConfirmDialog implements AfterContentInit, OnInit, OnDestroy {
 
     destroyStyle() {
         if (this.styleElement) {
-            document.head.removeChild(this.styleElement);
+            this.document.head.removeChild(this.styleElement);
             this.styleElement = null;
         }
     }

diff --git a/src/app/components/confirmpopup/confirmpopup.ts b/src/app/components/confirmpopup/confirmpopup.ts
@@ -151,7 +151,7 @@ export class ConfirmPopup implements OnDestroy {
     onAnimationStart(event: AnimationEvent) {
         if (event.toState === 'open') {
             this.container = event.element;
-            document.body.appendChild(this.container);
+            this.document.body.appendChild(this.container);
             this.align();
             this.bindListeners();
 
@@ -333,7 +333,7 @@ export class ConfirmPopup implements OnDestroy {
 
     restoreAppend() {
         if (this.container) {
-            document.body.removeChild(this.container);
+            this.document.body.removeChild(this.container);
         }
 
         this.onContainerDestroy();

diff --git a/src/app/components/dynamicdialog/dialogservice.ts b/src/app/components/dynamicdialog/dialogservice.ts
@@ -42,7 +42,7 @@ export class DialogService {
         this.appRef.attachView(componentRef.hostView);
 
         const domElem = (componentRef.hostView as EmbeddedViewRef<any>).rootNodes[0] as HTMLElement;
-        document.body.appendChild(domElem);
+        this.document.body.appendChild(domElem);
 
         this.dialogComponentRefMap.set(dialogRef, componentRef);
 

diff --git a/src/app/components/scrollpanel/scrollpanel.ts b/src/app/components/scrollpanel/scrollpanel.ts
@@ -159,10 +159,10 @@ export class ScrollPanel implements AfterViewInit, AfterContentInit, OnDestroy {
         this.lastPageY = e.pageY;
         DomHandler.addClass(this.yBarViewChild.nativeElement, 'p-scrollpanel-grabbed');
 
-        DomHandler.addClass(document.body, 'p-scrollpanel-grabbed');
+        DomHandler.addClass(this.document.body, 'p-scrollpanel-grabbed');
 
-        document.addEventListener('mousemove', this.onDocumentMouseMove);
-        document.addEventListener('mouseup', this.onDocumentMouseUp);
+        this.document.addEventListener('mousemove', this.onDocumentMouseMove);
+        this.document.addEventListener('mouseup', this.onDocumentMouseUp);
         e.preventDefault();
     }
 
@@ -171,10 +171,10 @@ export class ScrollPanel implements AfterViewInit, AfterContentInit, OnDestroy {
         this.lastPageX = e.pageX;
         DomHandler.addClass(this.xBarViewChild.nativeElement, 'p-scrollpanel-grabbed');
 
-        DomHandler.addClass(document.body, 'p-scrollpanel-grabbed');
+        DomHandler.addClass(this.document.body, 'p-scrollpanel-grabbed');
 
-        document.addEventListener('mousemove', this.onDocumentMouseMove);
-        document.addEventListener('mouseup', this.onDocumentMouseUp);
+        this.document.addEventListener('mousemove', this.onDocumentMouseMove);
+        this.document.addEventListener('mouseup', this.onDocumentMouseUp);
         e.preventDefault();
     }
 
@@ -216,10 +216,10 @@ export class ScrollPanel implements AfterViewInit, AfterContentInit, OnDestroy {
     onDocumentMouseUp(e: Event) {
         DomHandler.removeClass(this.yBarViewChild.nativeElement, 'p-scrollpanel-grabbed');
         DomHandler.removeClass(this.xBarViewChild.nativeElement, 'p-scrollpanel-grabbed');
-        DomHandler.removeClass(document.body, 'p-scrollpanel-grabbed');
+        DomHandler.removeClass(this.document.body, 'p-scrollpanel-grabbed');
 
-        document.removeEventListener('mousemove', this.onDocumentMouseMove);
-        document.removeEventListener('mouseup', this.onDocumentMouseUp);
+        this.document.removeEventListener('mousemove', this.onDocumentMouseMove);
+        this.document.removeEventListener('mouseup', this.onDocumentMouseUp);
         this.isXBarClicked = false;
         this.isYBarClicked = false;
     }

diff --git a/src/app/components/speeddial/speeddial.ts b/src/app/components/speeddial/speeddial.ts
@@ -322,13 +322,13 @@ export class SpeedDial implements AfterViewInit, AfterContentInit, OnDestroy {
 
                 this.isItemClicked = false;
             };
-            document.addEventListener('click', this.documentClickListener);
+            this.document.addEventListener('click', this.documentClickListener);
         }
     }
 
     unbindDocumentClickListener() {
         if (this.documentClickListener) {
-            document.removeEventListener('click', this.documentClickListener);
+            this.document.removeEventListener('click', this.documentClickListener);
             this.documentClickListener = null;
         }
     }