Add other methods #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulsamways
reviewed
Jul 24, 2024
paulsamways
reviewed
Jul 25, 2024
paulsamways
reviewed
Jul 26, 2024
argus.js
Outdated
| @@ -12,8 +12,13 @@ const ArgusJS = function(token) { | |||
| }, false); | |||
|
|
|||
| return { | |||
| token: () => currentToken, | |||
| get: (url) => fetch(url, { "method": "GET", "headers": { "Authorization": "Token " + currentToken } }) | |||
| get: (url) => fetch(`${mdr_url}${url}`, { "method": "GET", "headers": { "Authorization": "Bearer " + currentToken.access } }), | |||
There was a problem hiding this comment.
Can we have a function to join the base URL and the path? It should handle the URL having a leading '/' or not.
e.g.,
const mdrURL = '...';
const buildURL = (path) => (new URL(path, mdrURL)).href;
paulsamways
reviewed
Jul 26, 2024
paulsamways
reviewed
Jul 30, 2024
| @@ -2,7 +2,7 @@ const MESSAGE_ARGUS_TOKEN_REFRESH = "argus-token-refresh"; | |||
| const MESSAGE_ARGUS_TOKEN_REQUEST = "argus-token-request"; | |||
| const MESSAGE_ARGUS_TOKEN_RESPONSE = "argus-token-response"; | |||
|
|
|||
| const ArgusJS = function(token) { | |||
| const ArgusJS = function(token, mdrUrl) { | |||
There was a problem hiding this comment.
You also need to update line 30 to include the URL:
resolve(ArgusJS(event.data.token)); -> resolve(ArgusJS(event.data.token, event.data.mdr_url));
paulsamways
suggested changes
Jul 30, 2024
Von-Puffin
requested changes
Jul 30, 2024
argus.js
Outdated
| token: () => currentToken, | ||
| get: (url) => fetch(url, { "method": "GET", "headers": { "Authorization": "Token " + currentToken } }) | ||
| get: (url) => fetch(`${mdrUrl}${url}`, { "method": "GET", "headers": { "Authorization": "Bearer " + currentToken.access } }), | ||
| post: (url, data) => fetch(`${mdrUrl}${url}`, { "method": "POST", "headers": { "Authorization": "Bearer " + currentToken.access }, body: JSON.stringify(data) }), |
There was a problem hiding this comment.
For all the http request types that have a body you need to explicitly define the content type in the headers as the following 'Content-Type': 'application/json; charset=UTF-8'
paulsamways
approved these changes
Aug 9, 2024
Von-Puffin
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.