Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tool call id #1085

Merged
merged 13 commits into from
Oct 30, 2024
Merged

feat: add tool call id #1085

merged 13 commits into from
Oct 30, 2024

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang requested a review from a team as a code owner October 30, 2024 02:22
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 30, 2024
axiomofjoy
axiomofjoy reviewed Oct 30, 2024
View reviewed changes
spec/semantic_conventions.md Outdated Show resolved Hide resolved
spec/semantic_conventions.md Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2024
@RogerHYang RogerHYang merged commit 4813de5 into main Oct 30, 2024
3 checks passed
@RogerHYang RogerHYang deleted the tool-call-id branch October 30, 2024 17:26
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Merged
@Parker-Stafford Parker-Stafford mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axiomofjoy axiomofjoy axiomofjoy left review comments

@Parker-Stafford Parker-Stafford Parker-Stafford approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[playground][instrumentation] tool call id semantic conventions
3 participants
@RogerHYang @axiomofjoy @Parker-Stafford