fix(playground): compare invocationName and canonical name in all places where we try to find invocation params #5428
+101
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces where we try to find invocation params
dosubot
bot
added
the
size:L
Parker-Stafford
commented
Nov 19, 2024
| @@ -275,7 +276,7 @@ export const InvocationParametersForm = ({ | |||
| updateInstanceModelInvocationParameters({ | |||
| instanceId: instance.id, | |||
| invocationParameters: instance.model.invocationParameters.map( | |||
| (p) => (p.invocationName === field.invocationName ? input : p) | |||
| (p) => (areInvocationParamsEqual(p, field) ? input : p) | |||
There was a problem hiding this comment.
@cephalization we might need to rethink the effect right above this, i think it should have caused a refresh of the form but did not when the stop parameter got its name updated. which i think it should have rerendered the form with the correct value at that point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5409
The bug was happening because the parameter
invocationNamewasstop, on the instance in the front end and the parameterinvocationNamewasstop_sequencecoming from the api. Until the values were filtered and coerced to match our api. (happened on first opening but did not cause an update to the form). Not sure why the form wasn't updating when the value got coerced however.Screen.Recording.2024-11-18.at.5.25.00.PM.mov