re-name utility to avoid rule of hooks

Arize-ai · Jan 13, 2022 · 0de64b6 · 0de64b6
1 parent 2fcbe58
commit 0de64b6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,5 +1,5 @@
 {
-  "version": "0.2.26",
+  "version": "0.2.27",
   "license": "MIT",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",

diff --git a/src/alert/Alert.tsx b/src/alert/Alert.tsx
@@ -5,7 +5,7 @@ import { classNames } from '../utils';
 import { Text } from '../content';
 import { Icon, CloseOutline } from '../icon';
 import { useSeverityStyle } from './useSeverityStyle';
-import { useSeverityIcon } from './useSeverityIcon';
+import { getSeverityIcon } from './getSeverityIcon';
 import { SeverityLevel } from '../types';
 export interface AlertProps {
   variant: SeverityLevel;
@@ -57,7 +57,7 @@ export const Alert = ({
   let variantStyle = useSeverityStyle(variant);
 
   if (!icon && showIcon) {
-    icon = useSeverityIcon(variant);
+    icon = getSeverityIcon(variant);
   }
   return (
     <div

diff --git a/src/alert/useSeverityIcon.tsx → src/alert/getSeverityIcon.tsx b/src/alert/useSeverityIcon.tsx → src/alert/getSeverityIcon.tsx
@@ -19,7 +19,7 @@ type IconOptions = {
    */
   filled?: boolean;
 };
-export function useSeverityIcon(
+export function getSeverityIcon(
   severity: SeverityLevel,
   { filled }: IconOptions = { filled: true }
 ) {

diff --git a/src/notification/Notice.tsx b/src/notification/Notice.tsx
@@ -3,7 +3,7 @@ import { css } from '@emotion/core';
 import { NoticeConfig } from './types';
 import { Text } from '../content';
 import { useSeverityStyle } from '../alert/useSeverityStyle';
-import { useSeverityIcon } from '../alert/useSeverityIcon';
+import { getSeverityIcon } from '../alert/getSeverityIcon';
 import { Icon, CloseOutline } from '../icon';
 import theme from '../theme';
 import { DEFAULT_EXPIRE_MS } from './constants';
@@ -38,6 +38,7 @@ export function Notice({
       return () => clearTimeout(timer);
     }
     return () => {}; // Void function
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
   // Get the styles for the specific variant
@@ -64,7 +65,7 @@ export function Notice({
           }
         `}
       >
-        {useSeverityIcon(variant)}
+        {getSeverityIcon(variant)}
 
         <Text elementType="h5" textSize="large" weight="heavy" color="inherit">
           {title}