fix: plugin min version (#1859)

__tests__/unit/services/plugin-manager.spec.js

@@ -1,7 +1,9 @@
 import { createLocalVue } from '@vue/test-utils'
+import { PLUGINS } from '@config'
 import { PluginManager } from '@/services/plugin-manager'
 import { PluginSandbox } from '@/services/plugin-manager/plugin-sandbox'
 import { PluginSetup } from '@/services/plugin-manager/plugin-setup'
+import npmAdapter from '@/services/plugin-manager/adapters/npm-adapter'
 import nock from 'nock'
 
 jest.mock('@/services/plugin-manager/plugin-sandbox.js')
@@ -84,6 +86,37 @@ describe('Plugin Manager', () => {
       await pluginManager.fetchPlugins(true)
       expect(pluginManager.fetchPluginsFromAdapter).toHaveBeenCalled()
     })
+
+    describe('fetchPluginsFromAdapter', () => {
+      it('should exclude plugins with minimum version above wallet version', async () => {
+        const validPlugin = {
+          name: 'test-plugin-1',
+          keywords: PLUGINS.keywords,
+          'desktop-wallet': {
+            minVersion: '1.0'
+          }
+        }
+        const invalidPlugin = {
+          name: 'test-plugin-2',
+          keywords: PLUGINS.keywords,
+          'desktop-wallet': {
+            minVersion: '3.0'
+          }
+        }
+
+        jest.spyOn(pluginManager, 'fetchLogo').mockReturnValue(null)
+        jest.spyOn(pluginManager, 'fetchImages').mockReturnValue([])
+        const spyNpm = jest.spyOn(npmAdapter, 'all').mockReturnValue([validPlugin, invalidPlugin])
+
+        pluginManager.setAdapter('npm')
+        await pluginManager.fetchPluginsFromAdapter()
+
+        expect(mockDispatch.mock.calls[0][0]).toBe('plugin/setAvailable')
+        expect(Object.keys(mockDispatch.mock.calls[0][1])).toEqual(['test-plugin-1'])
+
+        spyNpm.mockRestore()
+      })
+    })
   })
 
   describe('Enable plugin', () => {

src/renderer/services/plugin-manager.js

@@ -249,6 +249,10 @@ export class PluginManager {
         plugin.images = []
       }
 
+      return plugin
+    }))
+
+    configs = configs.filter(plugin => {
       const validName = validatePackageName(plugin.id).validForNewPackages
       if (!validName) {
         console.info(`${plugin.id} is not a valid package name`)
@@ -259,10 +263,8 @@ export class PluginManager {
         console.info(`${plugin.id} requires a higher wallet version`)
       }
 
-      if (validName && minVersionSatisfied) {
-        return plugin
-      }
-    }))
+      return validName && minVersionSatisfied
+    })
 
     const plugins = configs.reduce((plugins, config) => {
       plugins[config.id] = { config }