Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor(plugins): add websocket methods #1451

Merged
merged 4 commits into from
Sep 16, 2019
Merged

refactor(plugins): add websocket methods #1451

merged 4 commits into from
Sep 16, 2019

Conversation

alessiodf
Copy link
Contributor

Partially fixes #1447 and increases websocket test coverage to 100%.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Sep 11, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Sep 11, 2019
@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #1451 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1451      +/-   ##
===========================================
+ Coverage    40.68%   40.73%   +0.04%     
===========================================
  Files          237      237              
  Lines         6572     6575       +3     
  Branches      1303     1295       -8     
===========================================
+ Hits          2674     2678       +4     
  Misses        3652     3652              
+ Partials       246      245       -1
Impacted Files Coverage Δ
src/renderer/services/plugin-manager/websocket.js 100% <100%> (+2.63%) ⬆️
src/renderer/components/Network/NetworkModal.vue 40.93% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca83eb9...f083d4d. Read the comment docs.

@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Sep 16, 2019
@ghost
Copy link

ghost commented Sep 16, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@alexbarnsley alexbarnsley added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Sep 16, 2019
@alexbarnsley alexbarnsley changed the title refactor: add websocket methods refactor(plugins): add websocket methods Sep 16, 2019
@alexbarnsley alexbarnsley merged commit 90cd976 into ArkEcosystem:develop Sep 16, 2019
@ghost
Copy link

ghost commented Sep 16, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Member Approved The pull request has been approved by a member. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins: cannot close websocket connections or set a message timeout
3 participants