Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

misc: add translate for pt-br #1465

Merged

Conversation

Pedro-Souza
Copy link
Contributor

add translate for pt-br

obs: The number formats file already exist for pt-br

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Sep 22, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost
Copy link

ghost commented Sep 22, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ghost ghost added the Complexity: Undetermined Needs specialized, in-depth review. label Sep 22, 2019
@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #1465 into develop will decrease coverage by 4.96%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1465      +/-   ##
===========================================
- Coverage    45.69%   40.73%   -4.97%     
===========================================
  Files          274      237      -37     
  Lines         6850     6575     -275     
  Branches      1342     1302      -40     
===========================================
- Hits          3130     2678     -452     
- Misses        3558     3651      +93     
- Partials       162      246      +84
Impacted Files Coverage Δ
src/renderer/services/plugin-manager.js 2.12% <0%> (-79.54%) ⬇️
...llet/WalletHeading/WalletHeadingPrimaryActions.vue 50% <0%> (-10%) ⬇️
...rc/renderer/components/MarketChart/MarketChart.vue 21.21% <0%> (-7.51%) ⬇️
src/renderer/store/modules/app.js 30% <0%> (-7.5%) ⬇️
src/renderer/store/modules/wallet.js 43.67% <0%> (-6.33%) ⬇️
...ents/Wallet/WalletSidebar/WalletSidebarFilters.vue 16% <0%> (-4.84%) ⬇️
src/renderer/services/client.js 68.83% <0%> (-4.1%) ⬇️
src/renderer/components/Modal/ModalWindow.vue 73.33% <0%> (-3.14%) ⬇️
src/renderer/components/Network/NetworkModal.vue 40.93% <0%> (-2.01%) ⬇️
src/renderer/store/modules/session.js 34.86% <0%> (-1.98%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057ee61...78f4e88. Read the comment docs.

Copy link
Member

@alexbarnsley alexbarnsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translations! Apologies for the delay, we have been trying to decide how to go about dealing with languages in the future. Our plan is to use plugins to provide languages externally. I will merge this but will not be merging anymore after it. Thank you!

@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Nov 21, 2019
@ghost
Copy link

ghost commented Nov 21, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@alexbarnsley alexbarnsley added the Bounty: Tier 3 Awarded for medium features, refactorings, improvements. This is valued at 50 USD. label Nov 21, 2019
@alexbarnsley alexbarnsley merged commit e75f836 into ArkEcosystem:develop Nov 21, 2019
@ghost
Copy link

ghost commented Nov 21, 2019

Your pull request has been merged and marked as tier 3. It will earn you $50 USD.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 3 Awarded for medium features, refactorings, improvements. This is valued at 50 USD. Complexity: Undetermined Needs specialized, in-depth review. Status: Member Approved The pull request has been approved by a member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants