This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: network modal missing version #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarnsley
requested review from
faustbrian,
ItsANameToo and
luciorubeens
as code owners
ghost
added
Complexity: Low
Codecov Report
@@ Coverage Diff @@
## develop #1469 +/- ##
===========================================
- Coverage 45.87% 45.82% -0.06%
===========================================
Files 274 274
Lines 6855 6865 +10
Branches 1343 1345 +2
===========================================
+ Hits 3145 3146 +1
- Misses 3548 3557 +9
Partials 162 162
Continue to review full report at Codecov.
|
ghost
mentioned this pull request
| .then(network => { | ||
| console.log('fetchNetworkConfig') | ||
| this.form.version = network.version.toString() | ||
| this.$error('Address Version was missing - please check your wallets') |
There was a problem hiding this comment.
Maybe move this to the locale file and remove debugging.
There was a problem hiding this comment.
Yes you're right 🤔 will do it a bit later on. Thanks 👌
3 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
Status: Stale
ghost
removed
the
Status: Stale
|
oops |
luciorubeens
approved these changes
Dec 5, 2019
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The network
versionvalue wasn't being saved in previous wallet versions. This is a patch to re-populate theversionfrom the network.Checklist