This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: parse uri #1529
Merged
fix: parse uri #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessiodf
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
added
Complexity: Low
ghost
mentioned this pull request
alexbarnsley
added
the
Bounty: Tier 4
alexbarnsley
approved these changes
Nov 14, 2019
ghost
added
the
Status: Member Approved
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
|
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue in #1520 only occurred if the desktop wallet was already open (i.e. the
second-instanceevent was called). It was caused by--original-process-start-timebeing added asargv[2]on Windows systems, meaning the URI handler received that string instead of the actual URI. Presumably there was a change to Electron or Chromium to either add that switch or it rearranged the order they were presented inargv.This PR resolves #1520 by iterating through all the
argvarray elements to find the URI. This should be more resilient in case any future Electron/Chromium changes modify the order again.Now works for me on Linux, macOS and Windows both when the wallet is closed and when it's already open.
Checklist