Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: plugins allow sandbox destroy #1578

Merged
merged 8 commits into from
Dec 9, 2019

Conversation

alexbarnsley
Copy link
Member

Summary

Fixes a bug where events do not get destroyed when plugins are disabled.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Dec 9, 2019
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #1578 into develop will increase coverage by 0.19%.
The diff coverage is 77.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1578      +/-   ##
===========================================
+ Coverage    45.52%   45.71%   +0.19%     
===========================================
  Files          274      274              
  Lines         6832     6875      +43     
  Branches      1337     1346       +9     
===========================================
+ Hits          3110     3143      +33     
- Misses        3561     3570       +9     
- Partials       161      162       +1
Impacted Files Coverage Δ
...r/services/plugin-manager/sandbox/route-sandbox.js 33.33% <ø> (ø) ⬆️
...ces/plugin-manager/sandbox/font-awesome-sandbox.js 100% <ø> (ø) ⬆️
...erer/services/plugin-manager/setup/themes-setup.js 86.66% <ø> (ø) ⬆️
...services/plugin-manager/setup/wallet-tabs-setup.js 100% <ø> (ø) ⬆️
...er/services/plugin-manager/sandbox/http-sandbox.js 100% <ø> (ø) ⬆️
...ervices/plugin-manager/setup/font-awesome-setup.js 0% <ø> (ø) ⬆️
.../services/plugin-manager/setup/menu-items-setup.js 91.66% <ø> (ø) ⬆️
...er/services/plugin-manager/setup/webframe-setup.js 100% <ø> (ø) ⬆️
...services/plugin-manager/sandbox/storage-sandbox.js 100% <ø> (ø) ⬆️
.../plugin-manager/sandbox/profile-current-sandbox.js 80% <ø> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7433fd...9319f41. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 547b23c into develop Dec 9, 2019
@ghost ghost deleted the refactor/plugins-destroy-sandbox branch December 9, 2019 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants