Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: added snap package #1663

Merged
merged 3 commits into from
Feb 20, 2020
Merged

feat: added snap package #1663

merged 3 commits into from
Feb 20, 2020

Conversation

dav1app
Copy link
Contributor

@dav1app dav1app commented Feb 11, 2020

Closes #1649. This creates a snap package for linux.

Summary

  • Create the package.
  • Publish the package on snapcraft.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Feb 11, 2020
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #1663 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1663   +/-   ##
========================================
  Coverage    62.95%   62.95%           
========================================
  Files          135      135           
  Lines         3663     3663           
  Branches       767      767           
========================================
  Hits          2306     2306           
  Misses        1134     1134           
  Partials       223      223

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06ae8a...9843b3b. Read the comment docs.

@alexbarnsley
Copy link
Member

@davimello28 What's the best way I can test this, assuming it's ready?

@brenopolanski
Copy link
Contributor

@davimello28 if you need an example of configuration options for snapcraft.yaml, here's an example of the vscode snapcraft.yaml file: https://github.com/microsoft/vscode/blob/master/resources/linux/snap/snapcraft.yaml

@dav1app
Copy link
Contributor Author

dav1app commented Feb 18, 2020

@davimello28 What's the best way I can test this, assuming it's ready?

You can do the following:

sudo snap install ark-desktop-wallet-linux-amd64-2.8.0.snap --dangerous

You can also add this to the build test. Everything worked properly here.

@faustbrian faustbrian marked this pull request as ready for review February 20, 2020 03:33
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Feb 20, 2020
@faustbrian faustbrian merged commit 40ed62b into develop Feb 20, 2020
@ghost ghost deleted the feat/linux-snap-package branch February 20, 2020 03:34
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: publish a Snap version of the desktop-wallet
4 participants