Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: replace various lodash methods with native alternatives #1759

Merged
merged 21 commits into from
Mar 3, 2020

Conversation

brenopolanski
Copy link
Contributor

Summary

This PR contains code for pure/native JavaScript functions as a replacement for Lodash.

Imports Removed:

  • _.findIndex()
  • _.capitalize()
  • _.upperFirst()
  • _.isUndefined()
  • _.isNil()
  • _.last()
  • _.first()
  • _.map()
  • _.isNull()
  • _.find()
  • _.isBoolean()
  • _.isObject()
  • _.isString()
  • _.filter()
  • _.min()
  • _.max()

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Mar 2, 2020
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #1759 into develop will decrease coverage by 0.15%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1759      +/-   ##
===========================================
- Coverage    60.49%   60.33%   -0.16%     
===========================================
  Files          363      363              
  Lines         9049     9049              
  Branches      1829     1828       -1     
===========================================
- Hits          5474     5460      -14     
- Misses        3399     3413      +14     
  Partials       176      176
Impacted Files Coverage Δ
src/renderer/services/client.js 96.23% <ø> (+0.73%) ⬆️
src/renderer/App.vue 22.3% <13.33%> (-1.84%) ⬇️
src/renderer/store/modules/peer.js 67.52% <66.66%> (ø) ⬆️
src/renderer/store/modules/market.js 4.34% <0%> (-13.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe82bc...1e4dc59. Read the comment docs.

@faustbrian faustbrian changed the title feat: remove some imports from lodash refactor: replace various lodash methods with native alternatives Mar 3, 2020
@faustbrian faustbrian merged commit 6554499 into develop Mar 3, 2020
@ghost ghost deleted the feat/remove-lodash-imports branch March 3, 2020 09:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants