This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
refactor: replace various lodash methods with native alternatives #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenopolanski
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
March 2, 2020 14:50
ghost
added
Complexity: Medium
Less than 256 lines changed.
Type: Feature
The issue is a request for new functionality.
labels
Mar 2, 2020
Codecov Report
@@ Coverage Diff @@
## develop #1759 +/- ##
===========================================
- Coverage 60.49% 60.33% -0.16%
===========================================
Files 363 363
Lines 9049 9049
Branches 1829 1828 -1
===========================================
- Hits 5474 5460 -14
- Misses 3399 3413 +14
Partials 176 176
Continue to review full report at Codecov.
|
faustbrian
changed the title
feat: remove some imports from lodash
refactor: replace various lodash methods with native alternatives
Mar 3, 2020
ghost
deleted the
feat/remove-lodash-imports
branch
March 3, 2020 09:27
ghost
mentioned this pull request
Mar 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Medium
Less than 256 lines changed.
Type: Feature
The issue is a request for new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains code for pure/native JavaScript functions as a replacement for Lodash.
Imports Removed:
_.findIndex()
_.capitalize()
_.upperFirst()
_.isUndefined()
_.isNil()
_.last()
_.first()
_.map()
_.isNull()
_.find()
_.isBoolean()
_.isObject()
_.isString()
_.filter()
_.min()
_.max()
Checklist