This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Remove deprecated 'electron-prebuilt' #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecation: electron-prebuilt has been renamed to electron egoist/vuepack#51 Fixes macOS build issues.
|
nice catch actually |
krau612
pushed a commit
to krau612/ark-desktop
that referenced
this pull request
Sep 16, 2017
Remove deprecated 'electron-prebuilt'
alexbarnsley
pushed a commit
that referenced
this pull request
Dec 3, 2018
* test: add PouchDB mocks and test the `DbInterface` class * feat: implement a class `Model` to use with `DbInterface` * refactor: rename the file of the instance * chore: add `pouchdb-debug` as a dependency and configure it * feat: add the `find`, `getAll` and `query` methods to `DbInterface` * fix: the `update` method of the `DbInterface` * docs: explain how revisions are managed in some of the `DbInterface` methods * test: update the tests of `DbInterface` * fix: problems of the `Model` class for using `__` on an attribute that is stored on PoucDB * feat: revamp the Vuex `DbModule` class to keep the reactivy on the `getters` * test: add 1 test to the `DbModule` class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes macOS build issues.
macOS >= 10.12.0 would not
npm run startafternpm install.Throwing error:
After removing deprecated dependency,
npm run startlaunches ark-desktop as expected.Reference
Empy package:
https://www.npmjs.com/package/electron-prebuilt
"The
electronpackage name on npm"electron-userland/electron-prebuilt#160
"deprecation: electron-prebuilt has been renamed to electron"
egoist/vuepack#51