Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: periodically update bridgechain list #1818

Merged
merged 6 commits into from
Mar 16, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Mar 11, 2020

Summary

Fixes #1817.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Mar 11, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #1818 into develop will decrease coverage by 0.01%.
The diff coverage is 61.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1818      +/-   ##
===========================================
- Coverage     60.1%   60.08%   -0.02%     
===========================================
  Files          369      369              
  Lines         9187     9200      +13     
  Branches      1878     1883       +5     
===========================================
+ Hits          5522     5528       +6     
- Misses        3480     3484       +4     
- Partials       185      188       +3
Impacted Files Coverage Δ
...nderer/components/Transaction/TransactionModal.vue 29% <0%> (-0.68%) ⬇️
src/renderer/services/transaction.js 90.12% <0%> (-3.47%) ⬇️
...llet/WalletBusiness/WalletBusinessBridgechains.vue 98.27% <91.66%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e965c09...32bd8f5. Read the comment docs.

@alexbarnsley
Copy link
Member

I'm not sure this will work as expected because it only reloads the bridgechain list after submitting the transaction (unless I misunderstood). The problem is that the transaction isn't forged instantly. I think it's best to have a timer on that bridgechain list to keep refreshing the list every minute or so to check for changes

@brenopolanski
Copy link
Contributor Author

brenopolanski commented Mar 13, 2020

@alexbarnsley
Copy link
Member

I partly think the fetchBridgechains method shouldn't clear the screen while loading. It looks weird because of the flicker where the data clears and re-appears 🤔

@alexbarnsley alexbarnsley changed the title fix: reload bridgechain list after the registration, update and resignation fix: periodically update bridgechain list Mar 16, 2020
@alexbarnsley alexbarnsley merged commit 507e99e into develop Mar 16, 2020
@alexbarnsley alexbarnsley deleted the feat/reload-bridgechain-registration branch March 16, 2020 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the bridgechain list is not updated automatically after registration
4 participants