Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: allow plugins to add languages #1848

Merged
merged 15 commits into from
Mar 20, 2020
Merged

feat: allow plugins to add languages #1848

merged 15 commits into from
Mar 20, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Mar 17, 2020

Summary

Adds the LANGUAGES permission which allows plugins to add new languages.

An example language plugin can be found at https://github.com/dated/italian-language-plugin

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Mar 17, 2020
@brenopolanski brenopolanski changed the title feat: allow plugins to add languages [WIP] feat: allow plugins to add languages Mar 17, 2020
@dated dated changed the title [WIP] feat: allow plugins to add languages feat: allow plugins to add languages Mar 18, 2020
@dated dated marked this pull request as ready for review March 18, 2020 19:13
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Mar 18, 2020
@faustbrian faustbrian added the Bounty: Tier 0 Custom reward at the discretion of the team, for large projects or changes. label Mar 19, 2020
brenopolanski
brenopolanski previously approved these changes Mar 19, 2020
@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Mar 19, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@dated
Copy link
Contributor Author

dated commented Mar 19, 2020

Just waiting for an icon from @olejegcord then it should be good to go.

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Mar 20, 2020
@ghost
Copy link

ghost commented Mar 20, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit a15c72c into ArkEcosystem:develop Mar 20, 2020
@ghost
Copy link

ghost commented Mar 20, 2020

Your pull request has been merged and marked as tier 0. It needs a specialized, in-depth review before we can decide on its value.

@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Mar 20, 2020
@dated dated deleted the feat/plugin-languages branch March 20, 2020 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 0 Custom reward at the discretion of the team, for large projects or changes. Complexity: High More than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Status: Member Approved The pull request has been approved by a member. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants