This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
feat: allow plugins to add languages #1848
Merged
faustbrian
merged 15 commits into
ArkEcosystem:develop
from
dated:feat/plugin-languages
Mar 20, 2020
Merged
feat: allow plugins to add languages #1848
faustbrian
merged 15 commits into
ArkEcosystem:develop
from
dated:feat/plugin-languages
Mar 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: High
More than 256 lines changed.
Type: Feature
The issue is a request for new functionality.
Status: In Progress
The issue or pull request is being worked on.
labels
Mar 17, 2020
brenopolanski
changed the title
feat: allow plugins to add languages
[WIP] feat: allow plugins to add languages
Mar 17, 2020
dated
changed the title
[WIP] feat: allow plugins to add languages
feat: allow plugins to add languages
Mar 18, 2020
dated
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
March 18, 2020 19:13
ghost
added
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
and removed
Status: In Progress
The issue or pull request is being worked on.
labels
Mar 18, 2020
faustbrian
added
the
Bounty: Tier 0
Custom reward at the discretion of the team, for large projects or changes.
label
Mar 19, 2020
brenopolanski
previously approved these changes
Mar 19, 2020
ghost
added
the
Status: Member Approved
The pull request has been approved by a member.
label
Mar 19, 2020
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Just waiting for an icon from @olejegcord then it should be good to go. |
ghost
added
the
Status: Contributor Approved
The pull request has been approved by a contributor.
label
Mar 20, 2020
faustbrian
approved these changes
Mar 20, 2020
A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged and marked as tier 0. It needs a specialized, in-depth review before we can decide on its value. |
ghost
removed
the
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
label
Mar 20, 2020
ghost
mentioned this pull request
Mar 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Bounty: Tier 0
Custom reward at the discretion of the team, for large projects or changes.
Complexity: High
More than 256 lines changed.
Status: Contributor Approved
The pull request has been approved by a contributor.
Status: Member Approved
The pull request has been approved by a member.
Type: Feature
The issue is a request for new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
LANGUAGES
permission which allows plugins to add new languages.An example language plugin can be found at https://github.com/dated/italian-language-plugin
Checklist