Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore(deps): update dependency html-webpack-plugin to v4 #1858

Merged
merged 7 commits into from
Apr 9, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 23, 2020

This PR contains the following updates:

Package Type Update Change
html-webpack-plugin devDependencies major ^3.2.0 -> ^4.0.0

Release Notes

jantimon/html-webpack-plugin

v4.0.1

Compare Source

Bug Fixes
  • update typedefs to match with html-minifier-terser (2698c7e)

v4.0.0

Compare Source

The summary can be found in the release blog post.

Bug Fixes
  • Add dependencies from the child compilation to the main compilation (27c3e72)
  • Add typing for assets(Close jantimon#​1243) (9fef060)
  • allow contenthash along with templatehash (049d4d3), closes #​1033
  • Catch and ignore pretty-error errors (2056139), closes #​921
  • Drop @​types/webpack dependency (d4eb1c7)
  • Ignore foreign child compilers (1422664)
  • Improve perfomance for appcache files (b94e043)
  • load script files before style files files in defer script loading mode (97f9fb9)
  • Prevent chunks from beeing added multiple times (d65b37d)
  • Prevent lodash from being inlined to work around a babel-loader incompatibility (7f21910), closes #​1223
  • Remove compilation.getStats() call for performance reasons (7005a55)
  • remove useless links for options (#​1153) (267e0e0)
  • Update references to html-minifier (24bf1b5), closes #​1311
  • typings.d.ts: added apply method type to HtmlWwbpackPlugin class definitoin (8b7255f), closes jantimon#​1244
  • rename contenthash to templatehash (4c11c5d)
  • Repair typings (#​1166) (f4cb241)
  • small type. minifcation instead of minification (#​1154) (56037a6)
  • Use src/index.ejs by default if present (#​1167) (c27e5e4)
  • chunksorter: Don't sort chunks by default (22fb03f)
  • loader: switch to loaderUtils.getOptions (a0a0f0d)
  • README: adds a link to template option documentation (f40aeae)
  • tests: Upgrade webpack-recompilation-simulator (dfe1d10)
  • Update lodash to 4.17.10 (cc3bf49)
Code Refactoring
  • Change the structure of the internal assets object (37db086)
  • Changed hook names and arguments - the hook order is 'beforeAssetTagGeneration', 'alterAssetTags', 'alterAssetTagGroups', 'afterTemplateExecution', 'beforeEmit', 'afterEmit' (14b4456)
  • Use Webpack 4 APIs (47efdea)
Features
  • add .toString implementation to htmlTags to allow easier rendering (34d8aa5)
  • Add default viewport meta tag for default template (302e39e), closes #​897 #​978
  • Add defer script loading (de315eb)
  • Add support for relative publicPath (dbbdd81)
  • Add support for tag (#​1160) (c5d4b86)
  • Add support for minifying inline ES6 inside html templates (c66766c), closes #​1262
  • Add support for the [contenthash] placeholder inside htm file names (ae8233a)
  • Add typings to package.json (a524e8f), closes #​1132
  • Allow to return async template parameters (99f9362)
  • drop workaround for "Uncaught TypeError: webpack_require(...) is not a function" to be compatible with webpack 5 (15ad0d2)
  • Export major version of this plugin (6ae6f48)
  • merge templateParameters with default template parameters (1d66e53)
  • Provide a verbose error message if html minification failed (7df269f)
  • compiler: Add file dependencies (bbc07a3)
  • compiler: Use a single compiler for multiple plugin instances (f29ae88)
  • compiler: Use timestamps to verify cache validity (0ebcd17)
  • Remove selfClosingTag (5d3d8e4)
  • Remove type="text/javascript" from injected script tags (b46bf67)
  • Replace jade with pug in examples (d7ec407)
  • Switch from jasmine to jest (ae1f435)
  • hooks: Add a helper for easier hook access (b6dec4b)
  • hooks: Provide static getHook method for access to all html-webpack-plugin hooks (#​995) (82b34a1)
  • Simplify element and charset attribute (55313be)
  • support ES6 template string in default loader (d6b65dd), closes #​950
  • Use jsdoc for static typing (a6b8d2d)
  • Use webpack 4 entries api to extract asset information (342867e)
  • html-tags: Add a helper to create html-tags (ee6a165)
BREAKING CHANGES
  • defaults: Use src/index.ejs if no template option is set.
  • defaults: The default template has now a predefined viewport meta tag
  • defaults: The default meta utf-8 declaration was changed to
  • hooks: Renamed beforeHtmlGeneration hook to beforeAssetTagGeneration
  • hooks: Renamed beforeHtmlProcessing hook to alterAssetTags
  • hooks: Renamed afterHtmlProcessing hook to beforeEmit
  • hooks: The html-webpack-plugin doesn't add its hooks to the compilation object anymore
  • The assets object which is used for the template parameters and inside hooks was changed. The chunks property was removed and the js and css property was converted from a string into an object { entryName: string, path: string}
  • The mimetype information "text/javascript" is removed from all generated script
    tags
  • Remove selfClosingTag attribute
  • Template strings inside templates are now disabled by default
  • Dropped support for Webpack 1 - 3
  • Template variable webpack was removed
  • chunksorter: Chunks aren't sorted anymore by default

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #1858 into develop will increase coverage by 2.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1858      +/-   ##
===========================================
+ Coverage    58.88%   60.94%   +2.06%     
===========================================
  Files          371      371              
  Lines         9306     9303       -3     
  Branches      1920     1920              
===========================================
+ Hits          5480     5670     +190     
+ Misses        3600     3462     -138     
+ Partials       226      171      -55     
Impacted Files Coverage Δ
...nderer/components/Transaction/TransactionModal.vue 29.00% <0.00%> (-1.07%) ⬇️
.../TransactionShow/TransactionShowMultiSignature.vue 26.47% <0.00%> (ø)
...PluginManagerButtons/PluginManagerButtonFilter.vue 100.00% <0.00%> (ø)
...c/renderer/components/Selection/SelectionTheme.vue 50.00% <0.00%> (+10.00%) ⬆️
src/renderer/store/modules/plugin.js 99.13% <0.00%> (+83.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ebf236...120b20f. Read the comment docs.

@renovate renovate bot force-pushed the renovate/html-webpack-plugin-4.x branch 3 times, most recently from ee8214e to 1762a70 Compare March 24, 2020 11:56
@renovate renovate bot force-pushed the renovate/html-webpack-plugin-4.x branch from 1762a70 to 9464475 Compare March 24, 2020 14:45
@renovate renovate bot force-pushed the renovate/html-webpack-plugin-4.x branch from 9464475 to a047ff5 Compare March 25, 2020 11:37
@dav1app
Copy link
Contributor

dav1app commented Mar 26, 2020

The bug was happening with a lot of packages. It is happening due to the changes in the API of html-webpack-plugin.

It was:

compilation.hooks.htmlWebpackPluginAfterEmit.tapAsync(...)

and now it is:

const HtmlWebpackPlugin = require('html-webpack-plugin')
//...
HtmlWebpackPlugin.getHooks(compilation).afterEmit.tapAsync(...)

I've also tried to update electron-builder and it doesn't seem to take any effect.

I'm writing this so others maybe find it useful due to the API break. It is not well documented.

@renovate
Copy link
Contributor Author

renovate bot commented Mar 26, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@alexbarnsley
Copy link
Member

@davimello28 could you resolve the conflicts please

@faustbrian faustbrian merged commit 72ef1a6 into develop Apr 9, 2020
@faustbrian faustbrian deleted the renovate/html-webpack-plugin-4.x branch April 9, 2020 03:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants