Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: rename minVersion property to minimumVersion #1865

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Mar 24, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Mar 24, 2020
@alexbarnsley alexbarnsley changed the base branch from develop to staging March 24, 2020 21:01
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #1865 into staging will increase coverage by 0.82%.
The diff coverage is 57.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1865      +/-   ##
===========================================
+ Coverage    60.01%   60.84%   +0.82%     
===========================================
  Files          369      370       +1     
  Lines         9232     9293      +61     
  Branches      1896     1918      +22     
===========================================
+ Hits          5541     5654     +113     
+ Misses        3500     3468      -32     
+ Partials       191      171      -20     
Impacted Files Coverage Δ
src/renderer/components/App/AppIntro/AppIntro.vue 37.50% <ø> (+6.25%) ⬆️
.../components/Menu/MenuDropdown/MenuDropdownItem.vue 100.00% <ø> (ø)
...rc/renderer/components/Modal/ModalConfirmation.vue 57.14% <ø> (ø)
src/renderer/pages/PluginManager.vue 23.77% <0.00%> (-0.69%) ⬇️
src/renderer/pages/Profile/ProfileEdition.vue 6.28% <0.00%> (-0.08%) ⬇️
src/renderer/services/image-manager.js 60.00% <0.00%> (-5.22%) ⬇️
...c/renderer/services/plugin-manager/plugin-setup.js 0.00% <ø> (ø)
...r/services/plugin-manager/setup/languages-setup.js 0.00% <0.00%> (ø)
src/renderer/store/modules/session.js 40.95% <ø> (+0.11%) ⬆️
src/renderer/store/modules/wallet.js 49.49% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c1ce8...a59d99a. Read the comment docs.

dated
dated previously approved these changes Mar 24, 2020
@alexbarnsley alexbarnsley dismissed dated’s stale review March 25, 2020 00:32

The base branch was changed.

@alexbarnsley alexbarnsley changed the base branch from staging to develop March 25, 2020 00:32
@alexbarnsley alexbarnsley changed the base branch from develop to staging March 25, 2020 00:32
@faustbrian faustbrian merged commit 4e5c4a8 into staging Mar 25, 2020
@ghost ghost deleted the refactor/min-version-property branch March 25, 2020 03:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants