Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: exclude empty wallets and don't show success message when canceling a save file dialog #1892

Merged
merged 3 commits into from
Apr 9, 2020

Conversation

brenopolanski
Copy link
Contributor

Summary

Fixes #1890 #1891.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@5ebf236). Click here to learn what that means.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1892   +/-   ##
==========================================
  Coverage           ?   58.86%           
==========================================
  Files              ?      371           
  Lines              ?     9307           
  Branches           ?     1921           
==========================================
  Hits               ?     5479           
  Misses             ?     3602           
  Partials           ?      226           
Impacted Files Coverage Δ
...c/renderer/components/Modal/ModalExportWallets.vue 33.84% <20.00%> (ø)
...derer/components/Network/NetworkSelectionModal.vue 16.66% <0.00%> (ø)
src/renderer/workers/bip38-worker.js 0.00% <0.00%> (ø)
...er/services/crypto/business-resignation.builder.js 100.00% <0.00%> (ø)
...rer/services/crypto/transaction-builder.service.js 100.00% <0.00%> (ø)
...erer/store/migrations/2.2.0 - initial migration.js 100.00% <0.00%> (ø)
...r/services/crypto/delegate-registration.builder.js 100.00% <0.00%> (ø)
...Manager/PluginManagerModals/PluginInstallModal.vue 87.50% <0.00%> (ø)
...vices/plugin-manager/sandbox/big-number-sandbox.js 25.00% <0.00%> (ø)
...renderer/components/Contact/ContactRenameModal.vue 25.00% <0.00%> (ø)
... and 362 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ebf236...02d70f4. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: it is not possible to export wallets excluding empty balance
2 participants