refactor: update block tx headings #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarnsley
requested review from
faustbrian,
ItsANameToo and
samharperpittam
as code owners
samharperpittam
requested changes
Jun 7, 2021
There was a problem hiding this comment.
There's a few pages that still require some changes to header sizes.
- Multipay Transaction.
Recipient Listshould be 24px - Multivote Transaction -
Multivoteshould be 24px - Multisig Transaction -
Participantsshould be 24px - Votes (
wallets/DJpFwW39QnQvQRQJF2MCfAoKvsX4DJ28jq/voters) -Votersshould be 24px - Generated Blocks - (
/wallets/DJpFwW39QnQvQRQJF2MCfAoKvsX4DJ28jq/blocks) -Block Historyshould be 24px.
|
should be done @samharperpittam |
ItsANameToo
requested changes
Jun 7, 2021
resources/views/app/block.blade.php
Outdated
| @@ -22,7 +22,7 @@ | |||
| <x-ark-container> | |||
| <div id="transaction-list" class="w-full"> | |||
| <div class="flex relative justify-between items-end mb-3"> | |||
| <h2>@lang('pages.block.transactions')</h2> | |||
| <h2 class="text-2xl">@lang('pages.block.transactions')</h2> | |||
There was a problem hiding this comment.
use proper header classes, either change it to h3 or whatever is needed, or use header-3 if the tag should be different from the styling
There was a problem hiding this comment.
@alexbarnsley above applies to a few files
There was a problem hiding this comment.
@ItsANameToo it's forced font size because they're 24px even on mobile devices. I didn't check the new ones Sam recommended though. I will check the things Sam asked to be changed too. Below is from the XD for the Block transactions headings
Largest device:
Smallest device:
ItsANameToo
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/kza8rb
Checklist