Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update block tx headings #797

Merged
merged 3 commits into from
Jun 8, 2021
Merged

refactor: update block tx headings #797

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4621ff
refactor: update block tx headings
alexbarnsley Jun 7, 2021
b0c0bfa
update other pages
alexbarnsley Jun 7, 2021
f9b101a
refactor: use h3 instead of all 24px
alexbarnsley Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/views/app/block.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<x-ark-container>
<div id="transaction-list" class="w-full">
<div class="flex relative justify-between items-end mb-3">
<h2>@lang('pages.block.transactions')</h2>
<h2 class="text-2xl">@lang('pages.block.transactions')</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use proper header classes, either change it to h3 or whatever is needed, or use header-3 if the tag should be different from the styling
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexbarnsley above applies to a few files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ItsANameToo it's forced font size because they're 24px even on mobile devices. I didn't check the new ones Sam recommended though. I will check the things Sam asked to be changed too. Below is from the XD for the Block transactions headings

Largest device:
image

Smallest device:
image

</div>

<livewire:block-transactions-table :block-id="$block->id()" />
Expand Down
2 changes: 1 addition & 1 deletion resources/views/components/page-headers/block.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="dark:bg-theme-secondary-900">
<x-ark-container container-class="flex flex-col space-y-6">
<h1 class="header-2">
<h1>
@lang('pages.block.title')
</h1>

Expand Down
2 changes: 1 addition & 1 deletion resources/views/components/page-headers/transaction.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="dark:bg-theme-secondary-900">
<x-ark-container container-class="flex flex-col space-y-6">
<h1 class="header-2">
<h1>
@lang('pages.transaction.title')
</h1>

Expand Down
4 changes: 3 additions & 1 deletion resources/views/components/transaction/extension/multi-payment.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<x-ark-container>
<div class="w-full">
<div class="flex relative justify-between items-end">
<h2>@lang('pages.transaction.recipient_list')</h2>
<h2 class="text-2xl">
@lang('pages.transaction.recipient_list')
</h2>
</div>


Expand Down
4 changes: 3 additions & 1 deletion resources/views/components/transaction/extension/multi-signature.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<x-ark-container>
<div class="w-full">
<div class="flex relative justify-between items-end">
<h2>@lang('pages.transaction.participants')</h2>
<h2 class="text-2xl">
@lang('pages.transaction.participants')
</h2>
</div>

<x-ark-tables.table class="hidden mt-5 md:block">
Expand Down
4 changes: 3 additions & 1 deletion resources/views/components/transaction/extension/vote-combination.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<x-ark-container>
<div class="w-full">
<div class="flex relative justify-between items-end">
<h2>@lang('general.transaction.types.vote-combination')</h2>
<h2 class="text-2xl">
@lang('general.transaction.types.vote-combination')
</h2>
</div>

<x-ark-tables.table class="hidden md:block">
Expand Down
4 changes: 3 additions & 1 deletion resources/views/livewire/wallet-block-table.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<div id="block-list" class="w-full">
@if($blocks->isNotEmpty())
<div class="flex relative justify-between items-center">
<h4>@lang('pages.blocks_by_wallet.table_title')</h4>
<h4 class="text-2xl">
@lang('pages.blocks_by_wallet.table_title')
</h4>
</div>

<x-skeletons.blocks without-generator>
Expand Down
4 changes: 3 additions & 1 deletion resources/views/livewire/wallet-voter-table.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<div id="block-list" class="w-full">
@if($wallets->isNotEmpty())
<div class="flex relative justify-between items-center">
<h4>@lang('pages.voters_by_wallet.subtitle')</h4>
<h4 class="text-2xl">
@lang('pages.voters_by_wallet.subtitle')
</h4>
</div>

<x-skeletons.wallets>
Expand Down