Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update icon references #1017

Merged
merged 33 commits into from
Jan 17, 2022
Merged

refactor: update icon references #1017

merged 33 commits into from
Jan 17, 2022

Conversation

leMaur
Copy link
Contributor

@leMaur leMaur commented Dec 9, 2021 •
edited
Loading

Summary

https://app.clickup.com/t/1wu1hfn
waiting on ArkEcosystem/laravel-foundation#95
waiting on ArkEcosystem/laravel-foundation#220

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@leMaur leMaur added the on-hold The issue or pull request is not being worked on for the time being. label Dec 9, 2021
@github-actions github-actions bot added the refactor The pull request improves or enhances an existing implementation. label Dec 9, 2021
@leMaur leMaur removed the on-hold The issue or pull request is not being worked on for the time being. label Jan 11, 2022
@leMaur leMaur marked this pull request as ready for review January 11, 2022 15:06
ItsANameToo
ItsANameToo requested changes Jan 13, 2022
View reviewed changes
Copy link
Member

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • footer ark icon should be red as it was before

image

@ItsANameToo
Copy link
Member

@leMaur also conflicts

@leMaur
Copy link
Contributor Author

leMaur commented Jan 13, 2022 •
edited
Loading

relies on ArkEcosystem/laravel-foundation#221

@ItsANameToo ItsANameToo merged commit 2ff08a7 into develop Jan 17, 2022
@ItsANameToo ItsANameToo deleted the refactor/icons branch January 17, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

@faustbrian faustbrian Awaiting requested review from faustbrian

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

Assignees
No one assigned
Labels
refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leMaur @ItsANameToo