Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use php-cs-fixer and rector config from foundation #974

Merged
merged 7 commits into from
Oct 18, 2021
Merged

refactor: use php-cs-fixer and rector config from foundation #974

merged 7 commits into from
Oct 18, 2021

Conversation

leMaur
Copy link
Contributor

@leMaur leMaur commented Oct 6, 2021 •
edited
Loading

Summary

https://app.clickup.com/t/1kagj9m
Waiting on #968
Waiting on ArkEcosystem/laravel-foundation#20
Waiting on ArkEcosystem/laravel-foundation#27
Waiting on ArkEcosystem/laravel-foundation#28

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@leMaur
Copy link
Contributor Author

leMaur commented Oct 12, 2021

I'll keep it draft until all static analysis errors are fixed.

@leMaur leMaur added the Status: On Hold The issue or pull request is not being worked on for the time being. label Oct 12, 2021
@leMaur leMaur changed the title [WIP] refactor: use php-cs-fixer, phpstan and rector config from foundation refactor: use php-cs-fixer, phpstan and rector config from foundation Oct 18, 2021
@leMaur leMaur marked this pull request as ready for review October 18, 2021 07:32
@faustbrian faustbrian changed the title refactor: use php-cs-fixer, phpstan and rector config from foundation refactor: use php-cs-fixer and rector config from foundation Oct 18, 2021
@leMaur leMaur removed the Status: On Hold The issue or pull request is not being worked on for the time being. label Oct 18, 2021
@faustbrian faustbrian merged commit 565897e into develop Oct 18, 2021
@faustbrian faustbrian deleted the refactor/move-config-files branch October 18, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

@faustbrian faustbrian Awaiting requested review from faustbrian

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leMaur @faustbrian