Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make group ID changes global #153

Closed
freghar opened this issue Oct 11, 2017 · 1 comment
Closed

Make group ID changes global #153

freghar opened this issue Oct 11, 2017 · 1 comment
Assignees
Labels
bug Issue that is not working as intended. change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time.
Milestone

Comments

@freghar
Copy link

freghar commented Oct 11, 2017

Zeus allows you, on group double-click, to change the group ID (also called callsign) of the group. This change however uses setGroupId, not setGroupIdGlobal, so any changes are local only to the Zeus player.

This is in Curator\Addons\ui_f_curator.pbo defined as

class RscAttributeGroupID : RscControlsGroupNoScrollbars {
	onSetFocus = "[_this,""RscAttributeGroupID"",'CuratorCommon'] call (uinamespace getvariable ""BIS_fnc_initCuratorAttribute"")";
        ...

which refers to RscAttributeGroupID meaning RscAttributeGroupID.sqf which is under ui_f_curator\UI\RscCommon\RscAttributeGroupID.sqf and contains

...
	case "confirmed": {
...
		if (_text != groupID _entity) then {
			_entity setgroupid [_text];
		};
...

Changing that setgroupid to setGroupIdGlobal should do the trick.
Even better, I would recommend removing the condition and doing the setGroupIdGlobal always, in case the Zeus client has already "desynced" group ID.

I would personally patch it by overriding just the onSetFocus line, but I've seen the Replacement directory in Achilles do it a bit differently (copying entire classes it seems), so I'll leave it up to you how to implement this, should you wish to accept this feature request.

Thanks!

@CreepPork CreepPork added change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. review Issue or PR that is being considered to be implemented or it's viability in Achilles. labels Oct 12, 2017
@CreepPork CreepPork self-assigned this Oct 12, 2017
@CreepPork CreepPork added this to the 0.1.0 milestone Oct 12, 2017
@CreepPork CreepPork added bug Issue that is not working as intended. and removed review Issue or PR that is being considered to be implemented or it's viability in Achilles. labels Oct 12, 2017
@CreepPork
Copy link
Member

This indeed is a bug and can be replicated on a dedicated server. Using setGroupIDGlobal does fix the issue and should, therefore, be used. The group ID only changes for the Curator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue that is not working as intended. change Issue or PR that will change a implemented feature. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time.
Projects
None yet
Development

No branches or pull requests

3 participants