Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code execution for units not available #234

Closed
Zakant opened this issue Jan 6, 2018 · 3 comments
Closed

Code execution for units not available #234

Zakant opened this issue Jan 6, 2018 · 3 comments
Labels
bug Issue that is not working as intended. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base.
Milestone
1.0.1

Comments

@Zakant
Copy link

Zakant commented Jan 6, 2018

Arma 3 Version: 1.80 (stable)
CBA Version: 3.5.0 (stable)
AresModAchillesExpansion Version: 1.0.0 (stable)

Mods:

- CBA_A3
- AresModAchillesExpansion
- ACE3

Description:
Code execution window for units is not available with Ares.

Steps to reproduce:

  • Join a dedicated server (where you are the admin).
  • Make sure "Enable DebugConsole" is set to true!
  • Login as admin.
  • Spawn a unit.
  • Open the units attributes and see the missing code execution window.

Where did the issue occur?

  • Dedicated
@CreepPork CreepPork added bug Issue that is not working as intended. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. labels Jan 6, 2018
@CreepPork
Copy link
Member

CreepPork commented Jan 6, 2018 •
edited
Loading

https://github.com/ArmaAchilles/AresModAchillesExpansion/blob/9dbf7c9525e0f24856931fdb235e36cbe8e8e681/%40AresModAchillesExpansion/addons/ui_f/scripts/RscDisplayAttributes.sqf#L48-L59

Under these circumstances, the dialog appears.

@CreepPork CreepPork added this to the Backlog milestone Jan 6, 2018
@Zakant
Copy link
Author

Zakant commented Jan 6, 2018

Thats right. But getMissionConfigValue ["enableDebugConsole", 0]; only checks if the config value was set and not if its controlled by a mission parameter. Mission params can be obtained by using "DebugConsole" call BIS_fnc_getParamValue; with 0 as disabled and 1 as enabled for (logged in) admins.
One solution would be to simply change this line to
private _enableDebugConsole = getMissionConfigValue ["enableDebugConsole", "DebugConsole" call BIS_fnc_getParamValue];
as BIS_fnc_getParamValue returns 0 if not present.

Kexanone added a commit that referenced this issue Jan 6, 2018
@Kexanone
Fixes #234
f29dfbd
@Kexanone Kexanone mentioned this issue Jan 6, 2018
Merged
Kexanone added a commit that referenced this issue Jan 6, 2018
@Kexanone
Hotfixes (#237)
7441e44 
* Fix: ACE3 arsenal for Create Custom

* Fix: ACE3 arsenal for Create Custom (part II)

* Fix: Add/remove editable objects

* New: getVirtualArsenal and updateVirtualArsenal

* Fixes #234

* Arsenal: use correct namespace and adjust getVirtualArsenal
@Kexanone Kexanone modified the milestones: Backlog, 1.0.1 Jan 6, 2018
@Kexanone
Copy link
Member

Kexanone commented Jan 6, 2018

Thx for the report, I just replaced that line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue that is not working as intended. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base.
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
3 participants
@CreepPork @Zakant @Kexanone