Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added universal target #270 #271

Merged
merged 3 commits into from
Mar 12, 2018
Merged

Added universal target #270 #271

merged 3 commits into from
Mar 12, 2018

Conversation

CreepPork
Copy link
Member

@CreepPork CreepPork commented Mar 10, 2018 •
edited
Loading

When merged this pull request will:

@CreepPork CreepPork added feature PR that adds a new feature to Achilles. change Issue or PR that will change a implemented feature. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. labels Mar 10, 2018
@CreepPork CreepPork added this to the 1.0.2 milestone Mar 10, 2018
@CreepPork CreepPork self-assigned this Mar 10, 2018
@CreepPork CreepPork requested a review from Kexanone March 10, 2018 14:12
Kexanone
Kexanone requested changes Mar 12, 2018
View reviewed changes
Copy link
Member

@Kexanone Kexanone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawless, but you should delete the obsolete stuff.

@CreepPork CreepPork merged commit a7b6a66 into master Mar 12, 2018
@CreepPork CreepPork deleted the universalTargetingModule branch March 12, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kexanone Kexanone Kexanone approved these changes

Assignees

@CreepPork CreepPork

Labels
change Issue or PR that will change a implemented feature. feature PR that adds a new feature to Achilles. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base.
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@CreepPork @Kexanone