Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework inventory attribute #455

Merged
merged 5 commits into from
Feb 17, 2019
Merged

Rework inventory attribute #455

merged 5 commits into from
Feb 17, 2019

Conversation

neilzar
Copy link
Collaborator

@neilzar neilzar commented Feb 14, 2019 •
edited
Loading

When merged this pull request will:

  • Improve first-load performance by 25-30%. In testing noticed a reduction from 8.6s to 6.0s with about 35 mods loaded.

@neilzar neilzar added change Issue or PR that will change a implemented feature. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/tested Indicates that the PR's latest commit has been tested and is working properly. labels Feb 14, 2019
@neilzar neilzar self-assigned this Feb 14, 2019
@neilzar neilzar added this to the 1.3.0 milestone Feb 14, 2019
@neilzar neilzar requested a review from CreepPork February 14, 2019 00:10
CreepPork
CreepPork requested changes Feb 16, 2019
View reviewed changes
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that comment, it looks good.

@AresModAchillesExpansion/addons/ui_f/scripts/RscAttributeInventory.sqf Outdated Show resolved Hide resolved
@CreepPork CreepPork merged commit d9ebb84 into ArmaAchilles:master Feb 17, 2019
@neilzar neilzar deleted the reworkInventoryAttribute branch February 20, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork approved these changes

Assignees

@neilzar neilzar

Labels
change Issue or PR that will change a implemented feature. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/tested Indicates that the PR's latest commit has been tested and is working properly.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neilzar @CreepPork