Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort music alphabetically and resume last track on re-open #483

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Sort music alphabetically and resume last track on re-open #483

merged 4 commits into from
Sep 18, 2019

Conversation

CreepPork
Copy link
Member

@CreepPork CreepPork commented May 3, 2019 •
edited
Loading

When merged this pull request will:

  • Sort music alphabetically
    • However, to achieve this you need to change the formatting of the track so it currently results in <Track name> (HH:MM)
  • Add a feature that resumes the last playing track if the module was reopened and nothing was selected (and the track is still in its length boundaries)

GIF demonstration

@CreepPork CreepPork added feature PR that adds a new feature to Achilles. change Issue or PR that will change a implemented feature. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/tested Indicates that the PR's latest commit has been tested and is working properly. labels May 3, 2019
@CreepPork CreepPork added this to the 1.3.0 milestone May 3, 2019
@CreepPork CreepPork requested review from neilzar and Kexanone May 3, 2019 16:41
@CreepPork CreepPork self-assigned this May 3, 2019
@CreepPork CreepPork added testing/tested Indicates that the PR's latest commit has been tested and is working properly. and removed testing/tested Indicates that the PR's latest commit has been tested and is working properly. labels May 3, 2019
@CreepPork
Copy link
Member Author

An alternate solution might be possible as the UMC addon dev version has this.

https://steamuserimages-a.akamaihd.net/ugc/796485732173958313/9B02EC55C2D0D44C37ABE5B407406C8CD89292DD/

@CreepPork CreepPork merged commit f2c7756 into master Sep 18, 2019
@CreepPork CreepPork deleted the sortMusicAlphabetically branch September 18, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kexanone Kexanone Kexanone approved these changes

@neilzar neilzar neilzar approved these changes

Assignees

@CreepPork CreepPork

Labels
change Issue or PR that will change a implemented feature. feature PR that adds a new feature to Achilles. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/tested Indicates that the PR's latest commit has been tested and is working properly.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CreepPork @neilzar @Kexanone