Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds More Animations #485

Merged
merged 9 commits into from
Sep 18, 2019
Merged

Adds More Animations #485

merged 9 commits into from
Sep 18, 2019

Conversation

Ryan180602
Copy link
Contributor

When merged this pull request will:

  • Add new animations from vanilla ArmA 3 to be used in Ambient Animations module.
  • Capitalised and beautified name of animations.
  • Removed "KNEEL" as it is unused (?).
  • Added new animations.

@CreepPork CreepPork requested review from Kexanone, CreepPork and neilzar and removed request for CreepPork May 11, 2019 17:15
@CreepPork CreepPork added change Issue or PR that will change a implemented feature. feature PR that adds a new feature to Achilles. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging. labels May 11, 2019
@CreepPork CreepPork added this to the 1.3.0 milestone May 11, 2019
Ryan180602 and others added 3 commits May 11, 2019 22:53
Ryan180602
Ryan180602 commented May 11, 2019
View reviewed changes
Copy link
Contributor Author

@Ryan180602 Ryan180602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed all the extra lines pointed out.

CreepPork
CreepPork reviewed May 14, 2019
View reviewed changes
@AresModAchillesExpansion/addons/functions_f_achilles/functions/features/fn_animation.sqf
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to be pedantic, but you could have left one newline in. As the original source.

@CreepPork
Copy link
Member

CreepPork commented May 14, 2019 •
edited
Loading

And is it tested? Singleplayer/multiplayer? Are you sure the kneel anim wasn't used?

@Ryan180602
Copy link
Contributor Author

Yeah tested in both. Kneel is not used anywhere, the identifier is not even referenced to in animation.sqf

@Ryan180602
Copy link
Contributor Author

Neither are the animations in kneel used

@CreepPork CreepPork added testing/tested Indicates that the PR's latest commit has been tested and is working properly. and removed testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging. labels May 14, 2019
@CreepPork
Copy link
Member

@neilzar @oOKexOo

@CreepPork CreepPork merged commit 29af7ab into ArmaAchilles:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilzar neilzar neilzar approved these changes

@CreepPork CreepPork CreepPork approved these changes

@Kexanone Kexanone Awaiting requested review from Kexanone

Assignees

@Ryan180602 Ryan180602

Labels
change Issue or PR that will change a implemented feature. feature PR that adds a new feature to Achilles. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/tested Indicates that the PR's latest commit has been tested and is working properly.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryan180602 @CreepPork @neilzar