Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ace medical update #517

Merged
merged 10 commits into from
Jan 19, 2020
Merged

Ace medical update #517

merged 10 commits into from
Jan 19, 2020

Conversation

DeliciousJaffa
Copy link
Contributor

When merged this pull request will:

  • Fix function name for ACE full heal to match rewrite
  • Remove deprecated ACE medical addVitalLoop (Should be handled by ace now)

@Kexanone Kexanone added fix PR that is a fixes a bug. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging. labels Jan 4, 2020
@Kexanone
Copy link
Member

Kexanone commented Jan 4, 2020

Looks fine, but it would probably be better to ensure backward compatibility in addition.

@unhappytroll
Copy link
Contributor

+1, my unit is not going to use new ACE, too many issues with new medical.

CreepPork
CreepPork requested changes Jan 11, 2020
View reviewed changes
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backwards compatibility is required for this to be merged.

@CreepPork CreepPork requested a review from Kexanone January 12, 2020 17:43
@DeliciousJaffa DeliciousJaffa removed their assignment Jan 12, 2020
@CreepPork CreepPork self-assigned this Jan 15, 2020
@Kexanone Kexanone merged commit 0e7f836 into ArmaAchilles:master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kexanone Kexanone Kexanone approved these changes

@CreepPork CreepPork CreepPork approved these changes

Assignees

@CreepPork CreepPork

Labels
fix PR that is a fixes a bug. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeliciousJaffa @Kexanone @unhappytroll @CreepPork