Property definition and check (#281)

ArnaudBuchholz · Aug 22, 2018 · 0881022 · 0881022
1 parent 21f88b9
commit 0881022
Showing 1 changed file with 29 additions and 16 deletions.
diff --git a/test/serial/property.js b/test/serial/property.js
@@ -4,40 +4,38 @@ describe("serial/property", function () {
 
     if (gpf.internals) {
 
-        var _gpfSerialPropertyCheck = gpf.internals._gpfSerialPropertyCheck;
+        var _gpfSerialPropertyCheck = gpf.internals._gpfSerialPropertyCheck,
+            values = [
+                "",
+                0,
+                1,
+                {},
+                new Date(),
+                true,
+                false,
+                "123"
+            ];
 
         describe("_gpfSerialPropertyCheck", function () {
 
             it("validates name", function () {
                 var exceptionCaught;
                 try {
                     _gpfSerialPropertyCheck({
-                        name: "OK",
-                        type: gpf.serial.types.string
+                        name: "OK"
                     });
                 } catch (e) {
                     exceptionCaught = e;
                 }
                 assert(!exceptionCaught);
             });
 
-            [
-                undefined,
-                0,
-                1,
-                {},
-                new Date(),
-                true,
-                false,
-                "",
-                "123"
-            ].forEach(function (invalidName) {
+            [undefined].concat(values).forEach(function (invalidName) {
                 it("rejects invalid names (" + JSON.stringify(invalidName) + ")", function () {
                     var exceptionCaught;
                     try {
                         _gpfSerialPropertyCheck({
-                            name: invalidName,
-                            type: gpf.serial.types.string
+                            name: invalidName
                         });
                     } catch (e) {
                         exceptionCaught = e;
@@ -46,6 +44,21 @@ describe("serial/property", function () {
                 });
             });
 
+            values.forEach(function (invalidType) {
+                it("rejects invalid types (" + JSON.stringify(invalidType) + ")", function () {
+                    var exceptionCaught;
+                    try {
+                        _gpfSerialPropertyCheck({
+                            name: "OK",
+                            type: invalidType
+                        });
+                    } catch (e) {
+                        exceptionCaught = e;
+                    }
+                    assert(exceptionCaught instanceof gpf.Error.InvalidSerialType);
+                });
+            });
+
         });
 
     }