Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #149 Address Values being lowercased #166

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

warrenbuckley
Copy link
Contributor

@warrenbuckley warrenbuckley commented Feb 9, 2024

This fixes #149 Address Values being lowercased @robertjf

The problem was that the entire JSON string was being lowercased to do some manipulation to the data, in doing so it lowercases the values in the JSON properties such as the Address.

Before Fix

image

image

After Fix

image

Test/Repro Notes

  • Run V13 example site
  • Use the textbox to enter in an address such as 'Umbraco' HQ's address
  • Visit frontend and observer the address is lowercased
  • Apply this PR/branch and re-run the site and view the frontend and the address data will not have been lowercased

@robertjf robertjf merged commit e45b1f5 into ArnoldV:develop Feb 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent address values from being format to all lowercase in views ?
2 participants