Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/webapp/new signup #65

Merged
merged 22 commits into from
Mar 4, 2024
Merged

Feat/webapp/new signup #65

merged 22 commits into from
Mar 4, 2024

Conversation

sergiorodriguezgarcia
Copy link
Contributor

Implementation of the Signup view with the corresponding tests, two of them can not pass because of the comunication with the backend.

Copy link
Contributor

@gony02 gony02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be OK 👍

import React, { useState } from "react";
import { useTranslation } from "react-i18next";
import { useNavigate } from "react-router-dom";
import { FaUserAlt, FaLock, FaAddressCard } from "react-icons/fa";
Copy link
Contributor

@jjgancfer jjgancfer Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to fail on this import. I'll approve when it is fixed.

@jjgancfer jjgancfer self-assigned this Mar 3, 2024
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sergiorodriguezgarcia sergiorodriguezgarcia linked an issue Mar 4, 2024 that may be closed by this pull request
Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it works now. Approved and merged.

@jjgancfer jjgancfer merged commit b2d0b56 into develop Mar 4, 2024
2 checks passed
@sergiorodriguezgarcia sergiorodriguezgarcia deleted the feat/webapp/new-signup branch March 5, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend 👁️ Frontend issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developing the signup page
3 participants