Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid credentials now returns descriptive error instead of generic one #68

Merged
merged 1 commit into from
Mar 3, 2024
Merged

fix: invalid credentials now returns descriptive error instead of generic one #68

merged 1 commit into from
Mar 3, 2024

Conversation

Toto-hitori
Copy link
Contributor

Invalid credentials now returns a 401 error that actually describes what went wrong instead of returning a 403 with a generic message.

@Toto-hitori Toto-hitori self-assigned this Mar 1, 2024
@Toto-hitori Toto-hitori mentioned this pull request Mar 1, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

jjgancfer
jjgancfer approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@jjgancfer jjgancfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does seem to solve the main issue with #66, which in the end was a clarity problem. Approved.

@UO283615 UO283615 merged commit 766e210 into develop Mar 3, 2024
2 checks passed
@UO283615 UO283615 deleted the fix/descriptive-errors branch March 3, 2024 10:46
@jjgancfer jjgancfer mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UO283615 UO283615 UO283615 approved these changes

@jjgancfer jjgancfer jjgancfer approved these changes

@sergioqfeg1 sergioqfeg1 Awaiting requested review from sergioqfeg1

Assignees

@Toto-hitori Toto-hitori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Toto-hitori @jjgancfer @UO283615