Fix issues with audio only streams. (lynckia#986)

Arri98 · Jul 27, 2017 · 40278fc · 40278fc
1 parent e6e8e55
commit 40278fc
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/erizo_controller/erizoClient/src/Events.js b/erizo_controller/erizoClient/src/Events.js
@@ -24,6 +24,9 @@ const EventDispatcher = () => {
 
   // It removes an available event listener.
   that.removeEventListener = (eventType, listener) => {
+    if (!dispatcher.eventListeners[eventType]) {
+      return;
+    }
     const index = dispatcher.eventListeners[eventType].indexOf(listener);
     if (index !== -1) {
       dispatcher.eventListeners[eventType].splice(index, 1);

diff --git a/erizo_controller/erizoClient/src/Room.js b/erizo_controller/erizoClient/src/Room.js
@@ -149,8 +149,8 @@ const Room = (altIo, altConnection, specInput) => {
           browser: stream.pc.browser }, undefined, () => {});
       },
       nop2p: true,
-      audio: stream.hasAudio(),
-      video: stream.hasVideo(),
+      audio: options.audio && stream.hasAudio(),
+      video: options.video && stream.hasVideo(),
       maxAudioBW: options.maxAudioBW,
       maxVideoBW: options.maxVideoBW,
       limitMaxAudioBW: spec.maxAudioBW,
@@ -437,7 +437,9 @@ const Room = (altIo, altConnection, specInput) => {
     if (options.maxVideoBW > spec.maxVideoBW) {
       options.maxVideoBW = spec.maxVideoBW;
     }
-    Logger.info('Checking subscribe options for', stream.getID());
+    options.audio = (options.audio === undefined) ? true : options.audio;
+    options.video = (options.video === undefined) ? true : options.video;
+    options.data = (options.data === undefined) ? true : options.data;
     stream.checkOptions(options);
     const constraint = { streamId: stream.getID(),
       audio: options.audio && stream.hasAudio(),

diff --git a/erizo_controller/erizoClient/src/webrtc-stacks/BaseStack.js b/erizo_controller/erizoClient/src/webrtc-stacks/BaseStack.js
@@ -30,8 +30,8 @@ const BaseStack = (specInput) => {
   specBase.remoteDescriptionSet = false;
 
   that.mediaConstraints = {
-    offerToReceiveVideo: (specBase.video !== undefined),
-    offerToReceiveAudio: (specBase.audio !== undefined),
+    offerToReceiveVideo: (specBase.video !== undefined && specBase.video !== false),
+    offerToReceiveAudio: (specBase.audio !== undefined && specBase.audio !== false),
   };
 
   that.peerConnection = new RTCPeerConnection(that.pcConfig, that.con);