Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like Stripe PHP lib is going to drop support of older PHP versions #64

Closed
erommel opened this issue Nov 18, 2018 · 3 comments
Closed

Comments

@erommel
Copy link
Contributor

erommel commented Nov 18, 2018

At the moment, it looks like they're going to drop PHP 5.4 and 5.5. soon: stripe/stripe-php#552

We're currently using older Stripe lib which is PHP 5.3 compatible. However, for new features (like webhooks API etc) we gonna need to update it to the latest lib version, which requires PHP 5.4 at least.

Since it appears some of our customers are still using PHP <=5.3, we need to add a notice for them to upgrade their PHP to 5.4 at least.

@erommel
Copy link
Contributor Author

erommel commented Nov 18, 2018

I have created a new branch and will try to play around with new Stripe Lib there: https://github.com/Arsenal21/stripe-payments/tree/testing

Repository owner deleted a comment from appthemes7 Nov 19, 2018
@Arsenal21
Copy link
Owner

Its totally okay to up the minimum requirement to PHP5.4 or 5.5. When we release the new version with PHP5.4 as the minimum requirment, We will have a BIG notice in the "Change Log" that mentions this. So that should take care of it (since it is a very small portion of users who use older than PHP5.4).

@erommel
Copy link
Contributor Author

erommel commented Feb 23, 2019

This is handled for now. Closing it to reopen when it's time to drop PHP 5.4 support.

@erommel erommel closed this as completed Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants