stripe-php v7.0.0

[ob-stripe]

cc @stripe/api-libraries

WIP PR for the next major release.

⚠️ = breaking change

• ⚠️ Drop support for PHP 5.4 (Drop support for PHP 5.4 #551)
• ⚠️ Drop support for PHP 5.5 (Drop support for PHP 5.5 #554)
• Bump dependencies (Bump dependencies #553)
• Remove CURLFile check (Remove CURLFile check #555)
• Update constant definitions for PHP >= 5.6 (Update constant definitions for PHP >= 5.6 #556)
• ⚠️ Remove FileUpload alias (Remove FileUpload alias #557)
• Remove curl_reset check (Remove curl_reset check #570)
• Use \Stripe\<class>::class constant instead of strings (Use \Stripe\<class>::class constant instead of strings #643)
• Use array_column to flatten params (Use array_column to flatten params #686)
• ⚠️ Remove deprecated methods (Remove deprecated methods #692)
• ⚠️ Remove IssuerFraudRecord (Remove IssuerFraudRecord #696)
• Update constructors of Stripe exception classes (Update constructors of Stripe exception classes #559)
• Fix remaining TODOs (Fix remaining TODOs #700)
• Use yield for autopagination (Use yield for autopagination #703)
• ⚠️ Rename fake magic methods and rewrite array conversion (Rename fake magic methods and rewrite array conversion #704)
• Add ErrorObject to Stripe exceptions (Add ErrorObject to Stripe exceptions #705)
• Start using PHP CS Fixer (Start using PHP CS Fixer #706)
• Update error messages for nested resource operations (Update error messages for nested resource operations #708)
• Upgrade retry logic (Upgrade retry logic #707)
• ⚠️ Collection improvements / fixes (Collection improvements / fixes #715)
• ⚠️ Modernize exceptions (Modernize exceptions #709)
• Add constants for error codes (Add constants for error codes #716)
• Update certificate bundle (Update certificate bundle #717)
• Retry requests on a 429 that's a lock timeout (Retry requests on a 429 that's a lock timeout #718)
• Fix toArray() calls (Fix toArray() calls #719)
• Couple of fixes for PHP 7.4 (Couple of fixes for PHP 7.4 #725)

Fixes #587 (via #704), fixes #702 (via #704), fixes #723 (via #725).

[browner12]

I'm not sure if this is planned already, but since this is targeting a new major version, I would suggest dropping support for PHP 5.6 and PHP 7.0 while you're at it. Both of these version will be losing security support by the end of the year.

http://php.net/supported-versions.php

Would be great to see a new major version more forward with only supported PHP versions, and allow users who require older PHP versions to stay on v6.

[ob-stripe]

Hey @browner12, thanks for the feedback!

I'm aware that security support for 5.6 and 7.0 will be ending soon, but our usage metrics show that usage for these versions is still very high: half of our PHP users that are currently on the 6.x branch are using one of these (25% on 5.6 and 25% on 7.0).

As it is, dropping support for 5.4 and 5.5 will prevent 6.5% of users (again, counting only users on the 6.x branch) from upgrading to 7.0 until they upgrade to a more recent PHP version. Bumping that number to 56.5% seems a little bit too steep for now.

That said, we will reevaluate in 2019 once support for 5.6 and 7.0 has actually ended, and might revisit this decision then.

[browner12]

Thanks for the response. Are you saying you guys would consider another major version (v8) after the new year?

I guess I don't see the downside of dropping the additional PHP versions. Even though the percentage of users on unsupported PHP versions is high, they will still be able to use this package by staying on v6. Users on supported PHP versions would be able to upgrade to v7.

I would say in the package community this is a pretty common practice of branching to a new major version and dropping old PHP support, which also helps drive adoption of newer versions of PHP.

[ob-stripe]

@browner12 Replying a bit late, sorry! As a developer, I agree with you entirely. However, many of Stripe's PHP users are not developers or even very technical persons and rely on e.g. Wordpress plugins for their Stripe integrations. It's an unfortunate reality that many hosting providers are not very diligent about keeping their PHP versions up to date, so dropping support for all but officially supported PHP versions would be a pretty harsh move for those users and would go against Stripe's philosophy of minimizing friction in accepting online payments.

As said above, we'll certainly reconsider this decision in a few months, and might release a new major version then.

[browner12]

Definitely agree, and understand where you're coming from.

I thought since this PR was for a Major release, it would be a good time to drop unsupported (or soon to be unsupported) versions of PHP.

People on older versions of PHP would still be able to use Stripe by sticking to v6, while other users could hop up to v7. Because Stripe is so popular, this would also add some pressure for people to start upgrading to a supported version of PHP.

You guys are also in a unique position because you accept payments meaning security is paramount to you (and should be to your users). When I see a website that accepts payments via Stripe, it gives me an extra bit of confidence that my information is secure. But knowing the website could be using Stripe, but also still be on an older version of PHP takes that confidence away.

We could discuss this forever, so I'll just say keep up the good work building this great product.

[rvitaliy]

@ob-stripe
Since PHP dropped the 5.6 & 7.0 support, I would suggest upgrading to 7.1 see supported versions.
So you can finally start using the types 🚀 and make this lib more secure 🔒

[ob-stripe]

@rvitaliy Thanks! However, we're going to keep supporting 5.6 and 7.0 for a bit longer despite these versions having reached end-of-life. See the discussion above for some justification.

[ob-stripe]

@brandur-stripe @remi-stripe I think this is more or less ready! I just need to finish writing up the migration guide: https://github.com/stripe/stripe-php/wiki/%5BWIP%5D-Migration-guide-for-v7.

Is there anything else you think we need to include in this release?

[remi-stripe]

Nothing comes to mind. I'm sure we'll think of something the day after release as usual :)

[brandur-stripe]

Haha, same Olivier. You already blew past any ideas that I had by about 10x.

Very exciting that we're getting close though!! Lemme know if there's anything else I can do to help get it across the finish line.

[ob-stripe]

Pulling this in!

[ob-stripe]

Released as v7.0.0 (obviously). Thanks everyone!